Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry Pick] Join enhancements and HLL type inference bug fix #16

Conversation

saahilbarai
Copy link

@saahilbarai saahilbarai commented Oct 28, 2024

Why I'm doing:

Cherry-picking PR - StarRocks#52021 from the main StarRocks branch to improve data distribution prior to joins in certain queries. More specifically, this issue was observed when profiling two very similar queries whose latencies were drastically different although joining on the same data. Upon investigation the faster query was distributed across more nodes going into a hash join operator. This should help improve data distribution prior to joins resolving the latency inconsistency.

Cherry-picking PR - StarRocks#51510 from the main StarRocks branch to resolve a type inference bug discovered when performing a union across two HLL typed columns across two distinct tables.

What I'm doing:

Cherry-picking PR - StarRocks#52021 and Cherry-picking PR - StarRocks#51510

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@saahilbarai saahilbarai changed the title [Enhancement] support insert local exchange in parttern exchange->join (#52021) [Cherry Pick] support insert local exchange in parttern exchange->join (#52021) Oct 28, 2024
@saahilbarai saahilbarai force-pushed the saahilbarai/cherrypick_exchange_enhancement_3.3 branch from 479ab28 to 6e62f41 Compare October 30, 2024 16:01
@saahilbarai saahilbarai changed the title [Cherry Pick] support insert local exchange in parttern exchange->join (#52021) [Cherry Pick] Join enhancements and HLL type inference bug fix Oct 30, 2024
@saahilbarai saahilbarai marked this pull request as ready for review October 30, 2024 16:03
@saahilbarai saahilbarai merged commit 27fd671 into pinterest-integration-3.3 Oct 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants