Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] support insert local exchange in parttern exchange->join #52021

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Oct 17, 2024

Why I'm doing:

set hash_join_interpolate_passthrough=true;
mysql>  select     count(lo_orderkey),count(y.k) from     lineorder l     right join (         select             s_suppkey
    from             supplier         where             s_suppkey < 2     ) r on l.lo_orderkey % 2 = r.s_suppkey     left join [
shuffl
+--------------------+------------+
| count(lo_orderkey) | count(y.k) |
+--------------------+------------+
|          300035459 |         12 |
+--------------------+------------+
1 row in set (4.01 sec)
set hash_join_interpolate_passthrough=false;

mysql>  select     count(lo_orderkey),count(y.k) from     lineorder l     right join (         select             s_suppkey
    from             supplier         where             s_suppkey < 2     ) r on l.lo_orderkey % 2 = r.s_suppkey     left join [shuffle](         select             "1" k         union all         select "1" k     ) y on y.k=lo_orderkey;
+--------------------+------------+
| count(lo_orderkey) | count(y.k) |
+--------------------+------------+
|          300035459 |         12 |
+--------------------+------------+
1 row in set (18.71 sec)

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@stdpain stdpain requested review from a team as code owners October 17, 2024 07:03
@wanpengfei-git wanpengfei-git requested a review from a team October 17, 2024 07:04
Copy link

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 10 / 11 (90.91%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/planner/NestLoopJoinNode.java 2 3 66.67% [131]
🔵 com/starrocks/sql/optimizer/rule/tree/JoinLocalShuffleRule.java 4 4 100.00% []
🔵 com/starrocks/sql/plan/PlanFragmentBuilder.java 1 1 100.00% []
🔵 com/starrocks/sql/optimizer/operator/physical/PhysicalJoinOperator.java 3 3 100.00% []

Copy link

[BE Incremental Coverage Report]

fail : 3 / 5 (60.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/cross_join_node.cpp 3 5 60.00% [627, 628]

@kangkaisen kangkaisen merged commit 9c16474 into StarRocks:main Oct 23, 2024
69 of 72 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Oct 23, 2024
Copy link

@Mergifyio backport branch-3.2

Copy link
Contributor

mergify bot commented Oct 23, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Oct 23, 2024

backport branch-3.2

✅ Backports have been created

@github-actions github-actions bot removed the 3.2 label Oct 23, 2024
mergify bot pushed a commit that referenced this pull request Oct 23, 2024
mergify bot pushed a commit that referenced this pull request Oct 23, 2024
wanpengfei-git pushed a commit that referenced this pull request Oct 23, 2024
saahilbarai pushed a commit to pinterest/starrocks that referenced this pull request Oct 25, 2024
saahilbarai pushed a commit to pinterest/starrocks that referenced this pull request Oct 25, 2024
saahilbarai pushed a commit to pinterest/starrocks that referenced this pull request Oct 25, 2024
saahilbarai pushed a commit to pinterest/starrocks that referenced this pull request Oct 25, 2024
saahilbarai pushed a commit to pinterest/starrocks that referenced this pull request Oct 28, 2024
chaoyli pushed a commit that referenced this pull request Oct 29, 2024
saahilbarai pushed a commit to pinterest/starrocks that referenced this pull request Oct 30, 2024
ZiheLiu pushed a commit to ZiheLiu/starrocks that referenced this pull request Oct 31, 2024
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
wanpengfei-git pushed a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants