Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for SDKMan config, and temporarily disabling #2019

Merged
merged 2 commits into from
May 12, 2023
Merged

Fix for SDKMan config, and temporarily disabling #2019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31c0bf9
Fix for SDKMan config, and temporarily disabling
shashachu May 12, 2023
c7829b7
updating CHANGELOG
shashachu May 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/publish-release-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
download-url: https://github.com/pinterest/ktlint/releases/download/${{ env.version }}/ktlint-${{ env.version }}.zip

- name: Release to sdkman
if: ${{ success() }}
if: false
env:
SDKMAN_KEY: ${{ secrets.SDKMAN_KEY }}
SDKMAN_TOKEN: ${{ secrets.SDKMAN_TOKEN }}
Expand Down
2 changes: 0 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ This project adheres to [Semantic Versioning](https://semver.org/).

### Added

* `ktlint` is now available on SDKMAN!

### Removed

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion ktlint-cli/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ tasks.withType<Test>().configureEach {
}

sdkman {
val sdkmanVersion = providers.environmentVariable("SDKMAN_KEY").orElse(project.version.toString())
val sdkmanVersion = providers.environmentVariable("SDKMAN_VERSION").orElse(project.version.toString())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

Sorry about that

candidate.set("ktlint")
version.set(sdkmanVersion)
url.set("https://github.com/pinterest/ktlint/releases/download/$sdkmanVersion/ktlint-$sdkmanVersion.zip")
Expand Down