Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for SDKMan config, and temporarily disabling #2019

Merged
merged 2 commits into from
May 12, 2023
Merged

Conversation

shashachu
Copy link
Contributor

Description

The SDKMan job was misconfigured. Fixing this, but also disabling releases to SDKMan for now.

Checklist

  • CHANGELOG.md is updated

@shashachu shashachu marked this pull request as ready for review May 12, 2023 16:53
@shashachu shashachu merged commit 432f609 into master May 12, 2023
@@ -142,7 +142,7 @@ tasks.withType<Test>().configureEach {
}

sdkman {
val sdkmanVersion = providers.environmentVariable("SDKMAN_KEY").orElse(project.version.toString())
val sdkmanVersion = providers.environmentVariable("SDKMAN_VERSION").orElse(project.version.toString())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

Sorry about that

@paul-dingemans paul-dingemans deleted the shasha/sdkman-fix branch May 14, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants