Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config(ticdc): mask more security query parameter #9832

Merged
merged 3 commits into from
Oct 7, 2023

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Oct 7, 2023

What problem does this PR solve?

Issue Number: close #9831

What is changed and how it works?

mask
"access-token",
"key",
"signature",
"credentials",
"private-key",
"client_secret",
"client_id",

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 7, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 7, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 7, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, nongfushanquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 7, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-07 02:36:30.673016539 +0000 UTC m=+846988.260126669: ☑️ agreed by 3AceShowHand.
  • 2023-10-07 02:53:39.048577393 +0000 UTC m=+848016.635687538: ☑️ agreed by nongfushanquan.

@sdojjy
Copy link
Member Author

sdojjy commented Oct 7, 2023

/retest-required

1 similar comment
@sdojjy
Copy link
Member Author

sdojjy commented Oct 7, 2023

/retest-required

@sdojjy sdojjy added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Oct 7, 2023
@ti-chi-bot ti-chi-bot bot merged commit 4e8db94 into pingcap:master Oct 7, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9835.

@sdojjy sdojjy deleted the mask-more-parameter-in-url branch October 7, 2023 09:29
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9836.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config(ticdc): mask more security query parameter
4 participants