Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ticdc): Fix kv ut meet panic: close of closed channel in cdc/kv (#4318) #4343

Merged
merged 9 commits into from
Jan 26, 2022
Merged

test(ticdc): Fix kv ut meet panic: close of closed channel in cdc/kv (#4318) #4343

merged 9 commits into from
Jan 26, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4318

What problem does this PR solve?

Issue Number: close #4135

What is changed and how it works?

(1) use atomic int to avoid close channel many times
(2) use a smaller connectionAge and heartbeat interval to shorten closed connection detcetion

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note 

`None`.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 16, 2022
Merged
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved component/kv-client TiKV kv log client component. component/test Unit tests and integration tests component. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR. labels Jan 16, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 16, 2022
@overvenus overvenus added this to the v5.1.4 milestone Jan 17, 2022
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 19, 2022
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/cherry-pick-not-approved labels Jan 19, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 24, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2022
@maxshuang
Copy link
Contributor

/run-dm-compatibility-test
/run-dm-integration-test
/run-kafka-integration-test
/run-integration-test

@maxshuang
Copy link
Contributor

/run-unit-test

@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: f362053

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 25, 2022
@ti-chi-bot ti-chi-bot merged commit 87e93fa into pingcap:release-5.1 Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@maxshuang maxshuang

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/kv-client TiKV kv log client component. component/test Unit tests and integration tests component. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR.
Projects
None yet
Milestone
v5.1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @maxshuang @overvenus @VelocityLight