Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panic: close of closed channel in cdc/kv #4135

Closed
Tracked by #2246
lance6716 opened this issue Dec 29, 2021 · 5 comments · Fixed by #4318
Closed
Tracked by #2246

panic: close of closed channel in cdc/kv #4135

lance6716 opened this issue Dec 29, 2021 · 5 comments · Fixed by #4318
Labels
area/ticdc Issues or PRs related to TiCDC. component/test Unit tests and integration tests component.

Comments

@lance6716
Copy link
Contributor

Which jobs are flaking?

CDC-UT

Which test(s) are flaking?

unit test github.com/pingcap/tiflow/cdc/kv

Jenkins logs or GitHub Actions link

panic: close of closed channel
goroutine 3486 [running]:
github.com/pingcap/tiflow/cdc/kv.(*clientSuite).TestRegionWorkerExitWhenIsIdle.func1.1(0xc001684240, 0xc0007641a0, 0xc002326120)
	/home/jenkins/agent/workspace/atom-ut/tiflow/cdc/kv/client_test.go:3348 +0x39
github.com/pingcap/tiflow/cdc/kv.(*clientSuite).TestRegionWorkerExitWhenIsIdle.func1(0x6b20130, 0xc00089aa50)
	/home/jenkins/agent/workspace/atom-ut/tiflow/cdc/kv/client_test.go:3359 +0x26e
github.com/pingcap/tiflow/cdc/kv.(*mockChangeDataService).EventFeed.func1(0xc001e14370, 0x6b20130, 0xc00089aa50)
	/home/jenkins/agent/workspace/atom-ut/tiflow/cdc/kv/client_test.go:255 +0x62
created by github.com/pingcap/tiflow/cdc/kv.(*mockChangeDataService).EventFeed
	/home/jenkins/agent/workspace/atom-ut/tiflow/cdc/kv/client_test.go:254 +0x38f

https://ci.pingcap.net/blue/organizations/jenkins/atom-ut/detail/atom-ut/7559/tests/

Anything else we need to know

  • Does this test exist for other branches as well?

  • Has there been a high frequency of failure lately?
@lance6716 lance6716 added the component/test Unit tests and integration tests component. label Dec 29, 2021
@lance6716 lance6716 mentioned this issue Dec 29, 2021
Closed
@lance6716 lance6716 added the area/ticdc Issues or PRs related to TiCDC. label Dec 29, 2021
@lance6716
Copy link
Contributor Author

https://ci2.pingcap.net/blue/organizations/jenkins/cdc_ghpr_leak_test/detail/cdc_ghpr_leak_test/16978/pipeline

@ben1009
Copy link
Contributor

ben1009 commented Dec 30, 2021

@maxshuang #2747 same issue again

@asddongmen
Copy link
Contributor

https://ci2.pingcap.net/blue/organizations/jenkins/cdc_ghpr_leak_test/detail/cdc_ghpr_leak_test/17251/pipeline

@asddongmen
Copy link
Contributor

https://ci.pingcap.net/blue/organizations/jenkins/atom-ut/detail/atom-ut/8278/tests/

@lance6716
Copy link
Contributor Author

https://ci2.pingcap.net/blue/organizations/jenkins/cdc_ghpr_test/detail/cdc_ghpr_test/14583/pipeline

@maxshuang maxshuang mentioned this issue Jan 13, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue Jan 16, 2022
test(ticdc): Fix kv ut meet panic: close of closed channel in cdc/kv (
36fdd53 
#4318)

close #4135
This was referenced Jan 16, 2022
Merged
Closed
Closed
Open
Closed
Closed
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this issue Jan 20, 2022
@zhaoxinyu
test(ticdc): Fix kv ut meet panic: close of closed channel in cdc/kv (
98f738f 
pingcap#4318)

close pingcap#4135
ti-chi-bot added a commit that referenced this issue Jan 26, 2022
@ti-chi-bot
test(ticdc): Fix kv ut meet panic: close of closed channel in cdc/kv (
87e93fa 
#4318) (#4343)

close #4135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. component/test Unit tests and integration tests component.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(ticdc): Fix kv ut meet panic: close of closed channel in cdc/kv
3 participants
@lance6716 @ben1009 @asddongmen