Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration_tests(ticdc): move integration tests into integration_tests dir (#3646) #3688

Merged
merged 4 commits into from
Dec 2, 2021
Merged

integration_tests(ticdc): move integration tests into integration_tests dir (#3646) #3688

merged 4 commits into from
Dec 2, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3646

What problem does this PR solve?

part of https://github.com/pingcap/ticdc/issues/2199

What is changed and how it works?

move integration tests into integration_tests dir.
Other test-related files will be moved to this directory later.

Check List

Tests

  • Integration test

Code changes

None

Side effects

None

Related changes

  • Need to cherry-pick to the release branch

Release note 

None

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 1, 2021
Merged
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. do-not-merge/cherry-pick-not-approved labels Dec 1, 2021
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 1, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 2, 2021
@Rustin170506 Rustin170506 force-pushed the cherry-pick-3646-to-release-4.0 branch from 8889c17 to 8398dff Compare December 2, 2021 03:38
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 2, 2021
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2021 •
edited
Loading

Codecov Report

Merging #3688 (06a9e71) into release-4.0 (753073a) will increase coverage by 3.1889%.
The diff coverage is 67.5456%.

@@                 Coverage Diff                 @@
##           release-4.0      #3688        +/-   ##
===================================================
+ Coverage      53.7661%   56.9550%   +3.1889%     
===================================================
  Files              153        168        +15     
  Lines            15958      19705      +3747     
===================================================
+ Hits              8580      11223      +2643     
- Misses            6475       7426       +951     
- Partials           903       1056       +153

@Rustin170506
Copy link
Member

/run-all-tests

@Rustin170506
Copy link
Member

/run-all-tests

@amyangfei amyangfei added this to the v4.0.16 milestone Dec 2, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 0c2c420

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 2, 2021
@Rustin170506
Copy link
Member

/run-all-tests

1 similar comment
@Rustin170506
Copy link
Member

/run-all-tests

@purelind
Copy link
Collaborator

purelind commented Dec 2, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 6283ec0 into pingcap:release-4.0 Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Rustin170506 Rustin170506

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Milestone
v4.0.16
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-chi-bot @codecov-commenter @Rustin170506 @amyangfei @purelind @zhouqiang-cl