Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration_tests(ticdc): move integration tests into integration_tests dir #3646

Merged
merged 6 commits into from
Dec 1, 2021
Merged

integration_tests(ticdc): move integration tests into integration_tests dir #3646

merged 6 commits into from
Dec 1, 2021

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

part of https://github.com/pingcap/ticdc/issues/2199

What is changed and how it works?

move integration tests into integration_tests dir.
Other test-related files will be moved to this directory later.

Check List

Tests

  • Integration test

Code changes

None

Side effects

None

Related changes

  • Need to cherry-pick to the release branch

Release note 

None

@Rustin170506 Rustin170506 added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. labels Nov 28, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 28, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 28, 2021
@Rustin170506 Rustin170506 changed the title integration_tests(ticdc): move integration tests into integration_tests dir WIP: integration_tests(ticdc): move integration tests into integration_tests dir Nov 28, 2021
@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 28, 2021
@Rustin170506 Rustin170506 changed the title WIP: integration_tests(ticdc): move integration tests into integration_tests dir integration_tests(ticdc): move integration tests into integration_tests dir Nov 30, 2021
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2021
@Rustin170506 Rustin170506 force-pushed the rustin-patch-integration-tests branch from 558fdb8 to 5a41cb6 Compare November 30, 2021 14:10
@Rustin170506
Copy link
Member Author

/run-copy

1 similar comment
@Rustin170506
Copy link
Member Author

/run-copy

@Rustin170506
Copy link
Member Author

/cc @amyangfei @overvenus

Integration tests passed!

@Rustin170506 Rustin170506 mentioned this pull request Dec 1, 2021
Merged
@Rustin170506
Copy link
Member Author

/hold

blocked by PingCAP-QE/ci#484

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2021 •
edited
Loading

Codecov Report

Merging #3646 (ff65618) into master (9f0bf6a) will increase coverage by 0.0047%.
The diff coverage is 61.9047%.

Flag Coverage Δ
cdc 57.4515% <61.9047%> (+0.0435%) ⬆️
dm 56.3615% <ø> (-0.0275%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #3646        +/-   ##
================================================
+ Coverage   56.8605%   56.8652%   +0.0047%     
================================================
  Files           456        456                
  Lines         54136      54077        -59     
================================================
- Hits          30782      30751        -31     
+ Misses        20158      20139        -19     
+ Partials       3196       3187         -9

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 1, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 1, 2021
@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c91723c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 1, 2021
@Rustin170506
Copy link
Member Author

/unhold

PingCAP-QE/ci#484 merging.

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2021
@Rustin170506
Copy link
Member Author

/run-all-tests

@Rustin170506
Copy link
Member Author

/run-integration-test

@ti-chi-bot ti-chi-bot merged commit facaeae into pingcap:master Dec 1, 2021
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 1, 2021
@Rustin170506 @ti-chi-bot
This is an automated cherry-pick of pingcap#3646
8889c17 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 1, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3688.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 1, 2021
@Rustin170506 @ti-chi-bot
This is an automated cherry-pick of pingcap#3646
ee03763 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 1, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3689.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 1, 2021
@Rustin170506 @ti-chi-bot
This is an automated cherry-pick of pingcap#3646
9fbc5ed 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 1, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3690.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 1, 2021
@Rustin170506 @ti-chi-bot
This is an automated cherry-pick of pingcap#3646
1d208db 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 1, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3691.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 1, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3692.

ti-chi-bot added a commit that referenced this pull request Dec 2, 2021
@ti-chi-bot
integration_tests(ticdc): move integration tests into integration_tes…
a3dd47b 
…ts dir (#3646) (#3690)
ti-chi-bot added a commit that referenced this pull request Dec 2, 2021
@ti-chi-bot
integration_tests(ticdc): move integration tests into integration_tes…
a4d46ee 
…ts dir (#3646) (#3691)
ti-chi-bot added a commit that referenced this pull request Dec 2, 2021
@ti-chi-bot
integration_tests(ticdc): move integration tests into integration_tes…
6283ec0 
…ts dir (#3646) (#3688)
ti-chi-bot added a commit that referenced this pull request Dec 2, 2021
@ti-chi-bot
integration_tests(ticdc): move integration tests into integration_tes…
7eaf424 
…ts dir (#3646) (#3692)
ti-chi-bot added a commit that referenced this pull request Dec 2, 2021
@ti-chi-bot
integration_tests(ticdc): move integration tests into integration_tes…
f18635a 
…ts dir (#3646) (#3689)
okJiang pushed a commit to okJiang/tiflow that referenced this pull request Dec 8, 2021
@Rustin170506 @okJiang
integration_tests(ticdc): move integration tests into integration_tes…
441acea 
…ts dir (pingcap#3646)
3AceShowHand pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 25, 2021
@ti-chi-bot @3AceShowHand
integration_tests(ticdc): move integration tests into integration_tes…
d928a2f 
…ts dir (pingcap#3646) (pingcap#3690)
@Rustin170506 Rustin170506 deleted the rustin-patch-integration-tests branch August 15, 2022 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@overvenus overvenus overvenus approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Rustin170506 @ti-chi-bot @codecov-commenter @lichunzhu @amyangfei @overvenus