-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storages: Fix obtaining incorrect column information when there are virtual columns in the query (release-8.1) #9265
Conversation
…irtual columns in the query (#9189) (#9206) close #9188 1. Use the original columns in `query_info.dag_query` instead of `columns_to_read` when building `RSOperator`. 2. For runtime filters, creating the `DM::Attr` object in `StorageDeltaMerge::read`, so it doesn't need to rely on `column_to_read`. Signed-off-by: ti-chi-bot <[email protected]> Co-authored-by: jinhelin <[email protected]>
/run-all-tests |
1 similar comment
/run-all-tests |
/run-all-tests |
/run-all-tests |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an manual cherry-pick of #9189
What problem does this PR solve?
Issue Number: close #9188
Problem Summary:
When parsing some column expressions, it may need to use column index to obtain column information, but since virtual columns are filtered out before being sent to the storage layer, the original columns and the columns for storage to read are
inconsistency.
What is changed and how it works?
columns_to_read
, the way that runtime filters creatingDM::Attr
object is modified.Check List
Tests
Side effects
Documentation
Release note