Storages: Fix obtaining incorrect column information when there are virtual columns in the query #9189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/work-in-progress
JinheLin
force-pushed
the
fix_column_to_read
branch
from
9fce9a5 to
3951444
Compare
JinheLin
changed the title
…n there are virtual columns in the query
JinheLin
force-pushed
the
fix_column_to_read
branch
from
6016504 to
01fd012
Compare
JinheLin
commented
Jul 8, 2024
| query_info.dag_query = std::make_unique<DAGQueryInfo>( | ||
| filter_conditions->conditions, | ||
| empty_pushed_down_filters, // Not care now | ||
| mockColumnInfosToTiDBColumnInfos(table_schema_for_delta_merge[table_id]), |
There was a problem hiding this comment.
Only local const references prolong the lifespan a temporary.
ref: https://stackoverflow.com/questions/2784262/
As a const reference member of DAGQueryInfo, source_columns cannot prolong the lifespan of a temporary.
DAGQueryInfo::source_columns will be a dangle reference after the contructor of DAGQueryInfo exits.
JinheLin
commented
Jul 8, 2024
| @@ -99,10 +99,14 @@ PushDownFilterPtr PushDownFilter::build( | |||
| has_cast) | |||
| { | |||
| NamesWithAliases project_cols; | |||
| for (size_t i = 0; i < columns_to_read.size(); ++i) | |||
There was a problem hiding this comment.
casted_columns align with table_scan_column_info one by one.
JinheLin
commented
Jul 8, 2024
| @@ -301,6 +303,8 @@ class StorageDeltaMerge | |||
| Context & global_context; | |||
|
|
|||
| LoggerPtr log; | |||
|
|
|||
| friend class MockStorage; | |||
There was a problem hiding this comment.
MockStorage will call getStoreColumnDefines().
JinheLin
changed the title
ti-chi-bot
bot
added
release-note
ti-chi-bot
bot
added
needs-1-more-lgtm
JinheLin
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
ti-chi-bot
added
needs-cherry-pick-release-7.5
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Jul 9, 2024
Signed-off-by: ti-chi-bot <[email protected]>
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Jul 9, 2024
Signed-off-by: ti-chi-bot <[email protected]>
12 tasks
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Jul 9, 2024
Signed-off-by: ti-chi-bot <[email protected]>
12 tasks
|
In response to a cherrypick label: new pull request created to branch |
JinheLin
added a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Jul 10, 2024
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Jul 11, 2024
…irtual columns in the query (#9189) (#9206) close #9188 1. Use the original columns in `query_info.dag_query` instead of `columns_to_read` when building `RSOperator`. 2. For runtime filters, creating the `DM::Attr` object in `StorageDeltaMerge::read`, so it doesn't need to rely on `column_to_read`. Signed-off-by: ti-chi-bot <[email protected]> Co-authored-by: jinhelin <[email protected]>
JinheLin
added a commit
that referenced
this pull request
Jul 29, 2024
…irtual columns in the query (#9189) (#9206) close #9188 1. Use the original columns in `query_info.dag_query` instead of `columns_to_read` when building `RSOperator`. 2. For runtime filters, creating the `DM::Attr` object in `StorageDeltaMerge::read`, so it doesn't need to rely on `column_to_read`. Signed-off-by: ti-chi-bot <[email protected]> Co-authored-by: jinhelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #9188
Problem Summary:
When parsing some column expressions, it may need to use column index to obtain column information, but since virtual columns are filtered out before being sent to the storage layer, the original columns and the columns for storage to read are
inconsistency.
What is changed and how it works?
columns_to_read, the way that runtime filters creatingDM::Attrobject is modified.Check List
Tests
Side effects
Documentation
Release note