Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update proxy of master to upgrade-near-8.2 #9148

Merged
merged 8 commits into from
Jun 15, 2024
Merged

update proxy of master to upgrade-near-8.2 #9148

merged 8 commits into from
Jun 15, 2024

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Jun 14, 2024 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: ref #4982, close #9147

Problem Summary:
update proxy to upgrade-near-8.2
Proxy PR:
Including:\nSubmodule contrib/tiflash-proxy 7dc50b4eb0..0d76d66782:

adapt to upgrade-near-8.2
Merge remote-tracking branch 'tikv/master' into upgrade-near-8.2
Add approvers (#373)
Strengthen configuration change approval (#371)
Add log for current ReadIndex mechanism (#370)
Add some tests for replica read (#369)

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 14, 2024
CalvinNeo added 5 commits June 14, 2024 15:17
@CalvinNeo
rust-toolchain
2c95c70 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
a
9331bca 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
d
2062bcd 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
z
d67b35d 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
a
76cda13 
Signed-off-by: CalvinNeo <[email protected]>
JinheLin
JinheLin approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@JinheLin JinheLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@ti-chi-bot ti-chi-bot bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 14, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 14, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-14 09:44:33.811962266 +0000 UTC m=+717027.865274189: ☑️ agreed by JinheLin.
  • 2024-06-14 09:45:20.539603502 +0000 UTC m=+717074.592915426: ☑️ agreed by Lloyd-Pottiger.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CalvinNeo
Copy link
Member Author

/retest

CalvinNeo added 2 commits June 15, 2024 10:42
@CalvinNeo
f
83b886b 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
u
6a9a0df 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2024
@CalvinNeo
Copy link
Member Author

/test

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 15, 2024

@CalvinNeo: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test pull-integration-test
  • /test pull-unit-test

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit c0ce779 into pingcap:master Jun 15, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@JinheLin JinheLin JinheLin approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TiFlash failed to replicate data from TiKV in the master branch
4 participants
@CalvinNeo @JaySon-Huang @JinheLin @Lloyd-Pottiger