[FLASH-762] Skippable place #373
Conversation
flowbehappy
changed the title
flowbehappy
changed the title
This comment has been minimized.
This comment has been minimized.
| @@ -45,6 +45,7 @@ struct DMContext : private boost::noncopyable | |||
| const size_t stable_chunk_rows; | |||
|
|
|||
| const bool enable_logical_split; | |||
| const bool enable_skippable_place; | |||
There was a problem hiding this comment.
We should fix broken tests after add field in DMContext.
| @@ -496,8 +496,9 @@ BlockInputStreams DeltaMergeStore::read(const Context & db_context, | |||
| } | |||
| #endif | |||
|
|
|||
| auto after_segment_read | |||
| = [&](const DMContextPtr & dm_context_, const SegmentPtr & segment_) { this->checkSegmentUpdate<false>(dm_context_, segment_); }; | |||
| // auto after_segment_read | |||
There was a problem hiding this comment.
Why disable checkSegmentUpdate in read?
| @@ -1043,8 +1043,8 @@ void DT_CLASS::addDelete(const UInt64 rid) | |||
| std::tie(leaf, delta) = findLeftLeaf<true>(rid); | |||
| std::tie(pos, delta) = leaf->searchRid(rid, delta); | |||
|
|
|||
| bool merge = false; | |||
| size_t merge_pos; | |||
| bool merge = false; | |||
There was a problem hiding this comment.
This changes have applied in #382, please rebase this branch.
| { | ||
| auto mvs = std::make_shared<DeltaValueSpace>(); | ||
| auto mvs = std::make_shared<DeltaValueSpace>(0); |
There was a problem hiding this comment.
I think it is better to hardcode handle col position only in Segment. Pass it as a param to DiskValueSpace:: getValueSpace.
| } | ||
| else | ||
| { | ||
| auto [actual_offset, actual_limit] |
There was a problem hiding this comment.
Better add comment indicates that, inside each chunk we ensure data is sort by handle & version in ascending order.
| } | ||
|
|
||
| auto block = doRead(); | ||
| if (block) |
There was a problem hiding this comment.
We can move this if check into beforeReturnBlock
| { | ||
| if constexpr (DM_RUN_CHECK) | ||
| { | ||
| ++num_read; |
There was a problem hiding this comment.
Should this line be moved to read()?
https://internal.pingcap.net/jira/browse/FLASH-762