DNM: [Flash 763] Imporve delta's performance by DMFile #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaySon-Huang
changed the title
JaySon-Huang
force-pushed
the
FLASH-763
branch
from
5aa709e to
763ac3f
Compare
Signed-off-by: JaySon-Huang <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
…n delta Signed-off-by: JaySon-Huang <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
…e finished. Signed-off-by: JaySon-Huang <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
set column_id for incoming blocks disable mark cached for APPENDING DMFile drop tables with DeltaMerge engine Signed-off-by: JaySon-Huang <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
JaySon-Huang
force-pushed
the
FLASH-763
branch
from
763ac3f to
2fc5e11
Compare
Signed-off-by: JaySon-Huang <[email protected]>
JaySon-Huang
commented
Jan 2, 2020
| @@ -80,7 +80,7 @@ class DeltaMergeBlockInputStream final : public IBlockInputStream, Allocator<fal | |||
|
|
|||
| public: | |||
| DeltaMergeBlockInputStream(const SkippableBlockInputStreamPtr & stable_input_stream_, | |||
| const DeltaValueSpacePtr & delta_value_space_, | |||
| const DeltaValuesPtr & delta_value_space_, | |||
There was a problem hiding this comment.
Rename param name
| for (auto & [extra_path, ids] : path_and_ids_vec) | ||
| { | ||
| for (auto id : ids) | ||
| { |
There was a problem hiding this comment.
What about move these code into StoragePool::gc
| using DeltaSpacePtr = std::shared_ptr<DeltaSpace>; | ||
|
|
||
| // TODO: rename this class to DeltaValueSpace? | ||
| class DeltaSpace |
There was a problem hiding this comment.
Rename this class to DeltaValueSpace
| @@ -82,6 +82,9 @@ class PageStorage | |||
|
|
|||
| PageId getNormalPageId(PageId page_id, SnapshotPtr snapshot = {}); | |||
|
|
|||
| // Given a set of page ids, return valid page ids in that set. | |||
| PageIdSet filterValidPages(const PageIdSet & pages, SnapshotPtr snapshot = {}); | |||
There was a problem hiding this comment.
We don't need this function in actual.
Signed-off-by: JaySon-Huang <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
JaySon-Huang
force-pushed
the
FLASH-763
branch
from
a74fe65 to
20ea5bb
Compare
flowbehappy
reviewed
Jan 7, 2020
Comment on lines
115
to
119
| if (writer) | ||
| writer->finalize(); | ||
| writer.reset(); | ||
| file_writting->enableGC(); | ||
| file_writting.reset(); |
There was a problem hiding this comment.
Put IO related logic here is quite weird and difficult to understand. Better do it clearly.
And I think writer->finalize() is not very necessary. While file_writting->enableGC() can be called after the first chunk committed in PageStorage.
JaySon-Huang
commented
Jan 7, 2020
| } | ||
| for (const auto & file_id : file_ids) | ||
| { | ||
| DMFilePtr file = DMFile::restore(file_id, 0, parent_path); |
There was a problem hiding this comment.
Should we remove no gc file for DMFile while restoring DeltaValueSpace?
Signed-off-by: JaySon-Huang <[email protected]>
JaySon-Huang
changed the title
|
This PR will make memory usage rapidly increase while size of data increase. Close it. |
This was referenced Sep 4, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use DMFile to store delta's data