-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue_template: add template for performance issue #9021
Merged
Merged
Changes from 2 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
e25f325
issue_template: add template for performance issue
winoros a299764
add more information
winoros e9f1553
eof
winoros cef73f3
Merge branch 'master' into refine-issue-template
lysu 7991d2e
address comments and add new thing
winoros d0f1846
Merge branch 'refine-issue-template' of https://github.com/winoros/ti…
winoros c535c84
Apply suggestions from code review
eurekaka 6551ff8
address comments
winoros b6dbfd2
Merge branch 'refine-issue-template' of https://github.com/winoros/ti…
winoros 417ebcf
address comment and add some more
winoros d029412
Merge branch 'master' into refine-issue-template
winoros a9d0198
address comments
winoros 4910d13
renaming file
winoros a162a07
Merge branch 'refine-issue-template' of https://github.com/winoros/ti…
winoros 62bf78e
Merge branch 'master' into refine-issue-template
winoros cc13e19
Merge branch 'master' into refine-issue-template
zz-jason 1bbe5e1
Merge branch 'master' into refine-issue-template
winoros File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
--- | ||
name: "\U0001F947 Performance Question" | ||
about: Performance question about TiDB which is not caused by bug. | ||
winoros marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
winoros marked this conversation as resolved.
Show resolved
Hide resolved
|
||
--- | ||
|
||
## Performance Question | ||
winoros marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
- What version of TiDB are you using (`tidb-server -V` or run `select tidb_version();` on TiDB)? | ||
winoros marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
- What's the difference between the performance you expect and the performance you observe? | ||
winoros marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
- Are you comparing TiDB with some other database? What's the difference between TiDB and compared one? | ||
winoros marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
- If it's a specific SQL query, could you please | ||
winoros marked this conversation as resolved.
Show resolved
Hide resolved
winoros marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- let us know whether you get your result after analyzing the table involved in the query. | ||
winoros marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- tell us whether this SQL always runs slowly, or just occasionally. | ||
winoros marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- provide the `EXPLAIN ANALYZE` result of this query if you can wait until this SQL's execution finishes and your TiDB version is no lower than 2.1, or you can just provide the `EXPLAIN` result. | ||
winoros marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- provide the plain text of the SQL and table schema so we can test it locally. It'll be more better if you can provide the dumped statistics information. | ||
winoros marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- use `show create table ${involved_table}\G` to get the table schema. | ||
- use `curl -G "http://${tidb-server-ip}:${tidb-server-status-port}/stats/dump/${db_name}/${table_name}" > ${table_name}_stats.json` to get the dumped statistics of one involved table. | ||
- provide the `EXPLAIN` result of the compared database. For mysql, `EXPLAIN format=json`'s result will be more helpful. | ||
winoros marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- other information that you think it's useful to distinguish the property of this SQL. | ||
winoros marked this conversation as resolved.
Show resolved
Hide resolved
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's strange that this line is marked as changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EOF issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a new line added. But seems no influence