Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue_template: add template for performance issue #9021

Merged
merged 17 commits into from
Feb 12, 2019

Conversation

winoros
Copy link
Member

@winoros winoros commented Jan 11, 2019

What problem does this PR solve?

Reporters report performance issue using current Question template.
It's not very suitable.

What is changed and how it works?

Add one more issue template for performance question.

Check List

Tests

  • No code

- [TiDB Doc](https://github.com/pingcap/docs)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's strange that this line is marked as changed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOF issue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a new line added. But seems no influence

@codecov-io
Copy link

codecov-io commented Jan 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@c3f64b2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9021   +/-   ##
=========================================
  Coverage          ?   67.26%           
=========================================
  Files             ?      371           
  Lines             ?    77234           
  Branches          ?        0           
=========================================
  Hits              ?    51950           
  Misses            ?    20644           
  Partials          ?     4640

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3f64b2...1bbe5e1. Read the comment docs.

@lysu
Copy link
Contributor

lysu commented Jan 13, 2019

/run-all-tests tidb-test=pr/715

@lysu
Copy link
Contributor

lysu commented Jan 13, 2019

/run-common-test tidb-test=pr/711

@lysu
Copy link
Contributor

lysu commented Jan 13, 2019

/run-integration-common-test tidb-test=pr/711

.github/ISSUE_TEMPLATE/performance-question.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/performance-question.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/performance-question.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/performance-question.md Outdated Show resolved Hide resolved
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 17, 2019
@xiekeyi98
Copy link
Contributor

LGTM

winkyao
winkyao previously approved these changes Jan 18, 2019
@zz-jason zz-jason dismissed winkyao’s stale review January 18, 2019 06:28

we may need to simplify some sentences

.github/ISSUE_TEMPLATE/performance-question.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/performance-question.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/performance-question.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/performance-question.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/performance-question.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/performance-question.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/performance-question.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/performance-question.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/performance-question.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/performance-question.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/performance-question.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/performance-question.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/performance-question.md Outdated Show resolved Hide resolved
@winoros winoros requested review from zz-jason and XuHuaiyu February 12, 2019 07:42
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 12, 2019
@winoros winoros merged commit 347c852 into pingcap:master Feb 12, 2019
@winoros winoros deleted the refine-issue-template branch February 12, 2019 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/docs status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.