*: upgrade grpc to 1.23.0 #12055

lysu · 2019-09-05T13:14:50Z

What problem does this PR solve?

test upgrade grpc from 1.17.0 to 1.23.0 in master

see more detail https://github.com/grpc/grpc-go/releases

What is changed and how it works?

go.mod

Check List

Tests

No code

Code changes

go.mod

Side effects

n/a

Related changes

n/a

This change is

lysu · 2019-09-05T13:15:01Z

/run-all-tests

lysu · 2019-09-05T14:08:22Z

/bench

sre-bot · 2019-09-05T18:08:18Z

@@                               Benchmark Diff                               @@
================================================================================
--- tidb: 161ff3c9abc3f70d7a6ad5656e7ecf60a5cb45f5
+++ tidb: 969c97a611ac06149362b767450050113277dafd
tikv: 4950eb1b6b996f8d1211033ba85eb7b2a51a67cf
pd: 144031c1bbde7152540e67b40fe32d01cc395c9f
================================================================================
tidb_max_cpu: 19.43, delta: 0.23%
tikv_max_cpu: 13.03, delta: 1.84%
tidb_max_memory: 1781.82 MiB, delta: -3.78%
tikv_max_memory: 59912.88 MiB, delta: 0.03%

Measured tpmC (NewOrders): 21966.52, delta: 0.08%

https://perf.pingcap.com

sre-bot · 2019-09-05T21:56:00Z

@@                               Benchmark Diff                               @@
================================================================================
--- tidb: 161ff3c9abc3f70d7a6ad5656e7ecf60a5cb45f5
+++ tidb: 969c97a611ac06149362b767450050113277dafd
tikv: 4950eb1b6b996f8d1211033ba85eb7b2a51a67cf
pd: 144031c1bbde7152540e67b40fe32d01cc395c9f
================================================================================
test-1: < oltp_insert >
    * QPS : 21382.60 ± 0.6473% (std=78.13) delta: -0.16%
    * AvgMs : 11.96 ± 0.6185% (std=0.04) delta: 0.15%
    * PercentileMs99 : 43.08 ± 1.0864% (std=0.38) delta: 1.10%
            
test-2: < oltp_update_non_index >
    * QPS : 29546.30 ± 0.3619% (std=62.06) delta: 0.31%
    * AvgMs : 8.66 ± 0.3464% (std=0.02) delta: -0.32%
    * PercentileMs99 : 30.48 ± 1.0827% (std=0.27) delta: -0.37%
            
test-3: < oltp_read_write >
    * QPS : 37054.96 ± 0.0951% (std=24.69) delta: 0.64%
    * AvgMs : 138.71 ± 0.0811% (std=0.07) delta: -0.64%
    * PercentileMs99 : 257.95 ± 0.0000% (std=0.00) delta: 0.00%
            
test-4: < oltp_point_select >
    * QPS : 74898.36 ± 1.5448% (std=697.57) delta: 1.20%
    * AvgMs : 3.42 ± 1.5214% (std=0.03) delta: -1.16%
    * PercentileMs99 : 7.48 ± 2.4325% (std=0.10) delta: 0.70%
            
test-5: < oltp_update_index >
    * QPS : 17006.34 ± 0.3784% (std=39.97) delta: -0.26%
    * AvgMs : 15.05 ± 0.3987% (std=0.04) delta: 0.24%
    * PercentileMs99 : 48.34 ± 0.0000% (std=0.00) delta: 0.73%

https://perf.pingcap.com

codecov · 2019-09-06T03:11:30Z

Codecov Report

Merging #12055 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12055   +/-   ##
===========================================
  Coverage   81.3509%   81.3509%           
===========================================
  Files           453        453           
  Lines         97426      97426           
===========================================
  Hits          79257      79257           
  Misses        12500      12500           
  Partials       5669       5669

lysu · 2019-09-06T05:26:55Z

/run-all-tests
/bench

sre-bot · 2019-09-06T06:20:05Z

@@                               Benchmark Diff                               @@
================================================================================
--- tidb: 0fbd21c0851e01f1508ca5baf99010294c438dc5
+++ tidb: acfecf12c66ba4572e9dd88a19abbcec2982e1bf
tikv: 7f7a3a682fad7389ba239c58e42159a94285869b
pd: 38ff102546450348b895c14aaa17ad440d02d037
================================================================================
tidb_max_cpu: 19.54, delta: 1.35%
tikv_max_cpu: 13.23, delta: -0.20%
tidb_max_memory: 1805.70 MiB, delta: -1.43%
tikv_max_memory: 59898.45 MiB, delta: 0.00%

Measured tpmC (NewOrders): 21945.82, delta: 0.17%

https://perf.pingcap.com

sre-bot · 2019-09-06T08:37:57Z

@@                               Benchmark Diff                               @@
================================================================================
--- tidb: 2ef6f46a6377dbaa045c9041b4ae797dc742a2ef
+++ tidb: acfecf12c66ba4572e9dd88a19abbcec2982e1bf
tikv: 7f7a3a682fad7389ba239c58e42159a94285869b
pd: ca5cae673101cdec5a9f5dbbe7d4b6c8d4928977
================================================================================
test-1: < oltp_insert >
    * QPS : 21317.36 ± 0.6289% (std=87.85) delta: -0.21%
    * AvgMs : 12.00 ± 0.6457% (std=0.05) delta: 0.22%
    * PercentileMs99 : 42.93 ± 2.8980% (std=0.79) delta: 0.74%
            
test-2: < oltp_update_non_index >
    * QPS : 29441.50 ± 0.5575% (std=105.45) delta: -0.46%
    * AvgMs : 8.69 ± 0.5983% (std=0.03) delta: 0.44%
    * PercentileMs99 : 30.81 ± 0.0000% (std=0.00) delta: 0.72%
            
test-3: < oltp_read_write >
    * QPS : 37019.30 ± 0.1555% (std=44.46) delta: -0.09%
    * AvgMs : 138.85 ± 0.1484% (std=0.17) delta: 0.08%
    * PercentileMs99 : 257.95 ± 0.0000% (std=0.00) delta: 0.00%
            
test-4: < oltp_point_select >
    * QPS : 75666.53 ± 1.9973% (std=879.11) delta: 1.90%
    * AvgMs : 3.38 ± 1.8913% (std=0.04) delta: -1.80%
    * PercentileMs99 : 7.46 ± 2.0923% (std=0.10) delta: 0.35%
            
test-5: < oltp_update_index >
    * QPS : 17104.92 ± 0.4784% (std=51.10) delta: 0.38%
    * AvgMs : 14.96 ± 0.4812% (std=0.05) delta: -0.40%
    * PercentileMs99 : 47.99 ± 1.0877% (std=0.43) delta: 0.00%

https://perf.pingcap.com

go.mod

owner/fail_test.go

zimulala · 2019-09-06T10:58:34Z

owner/fail_test.go

+	var stop sync.WaitGroup
+	stop.Add(1)
+	go func() {
+		if err = srv.Serve(ln); err != nil {


Why do we call this function in this test?

because this test will be failed after upgrade grpc due can not establish connection to net.Listen("unix", "new_session:12379"), old grpc can be ready before handshake success, but in new grpc this changed(grpc/grpc-go#2406), so we need setup a grpc serve for listened port

lysu · 2019-09-10T11:39:13Z

/rebuild

tiancaiamao

go mod tidy fail

tiancaiamao · 2019-09-11T11:36:54Z

tools/check/go.mod

@@ -20,3 +20,5 @@ require (
 	gopkg.in/yaml.v2 v2.2.2 // indirect
 	honnef.co/go/tools v0.0.0-20180920025451-e3ad64cb4ed3
 )
+
+go 1.13


zz-jason

It's better not to mix the bugfixes and package upgrades together in one PR.

store/tikv/test_util.go

tiancaiamao · 2019-09-12T05:34:03Z

LGTM

zz-jason

LGTM

sre-bot · 2019-09-12T05:36:44Z

Your auto merge job has been accepted, waiting for 12164, 12083

sre-bot · 2019-09-12T05:55:17Z

/run-all-tests

lysu added the component/tikv label Sep 5, 2019

lysu requested review from tiancaiamao and zimulala September 6, 2019 09:21

lysu added the status/all tests passed label Sep 6, 2019

zimulala reviewed Sep 6, 2019

View reviewed changes

tiancaiamao reviewed Sep 11, 2019

View reviewed changes

lysu added 11 commits September 11, 2019 19:54

*: upgrade grpc to 1.23.0

48d8fcf

fix test due to grpc/grpc-go#2406

fd11732

fix leak

2a723cf

fix test

dbba4e8

fix go mode tidy use google/uuid for ddl

5d5fb36

fix leak

d0c2dc8

fix leak

d1e7c2a

address comment

0b1818f

remove go1.13 in go.mod

4194d01

...

164e747

...

75d5b7c

zz-jason reviewed Sep 12, 2019

View reviewed changes

store/tikv/test_util.go Show resolved Hide resolved

lysu added 2 commits September 12, 2019 11:07

test

0ef3e88

Merge branch 'master' into upgrade-grpc-to-1.23

8de2bc8

tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 12, 2019

zz-jason approved these changes Sep 12, 2019

View reviewed changes

zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 12, 2019

Merge branch 'master' into upgrade-grpc-to-1.23

adf0387

sre-bot merged commit 5c48d93 into pingcap:master Sep 12, 2019

This was referenced Sep 24, 2019

Write binlog failed, the last error no avaliable pump to write binlog pingcap/tidb-binlog#753

Closed

upgrade grpc to 1.23 pingcap/tidb-binlog#756

Merged

tiancaiamao mentioned this pull request Oct 9, 2019

*: fix go mod tidy in Go1.13 (12055) #12560

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: upgrade grpc to 1.23.0 #12055

*: upgrade grpc to 1.23.0 #12055

lysu commented Sep 5, 2019 •

edited

Loading

lysu commented Sep 5, 2019

lysu commented Sep 5, 2019

sre-bot commented Sep 5, 2019

sre-bot commented Sep 5, 2019

codecov bot commented Sep 6, 2019 •

edited

Loading

lysu commented Sep 6, 2019

sre-bot commented Sep 6, 2019

sre-bot commented Sep 6, 2019

zimulala Sep 6, 2019

lysu Sep 10, 2019

lysu commented Sep 10, 2019

tiancaiamao left a comment

tiancaiamao Sep 11, 2019

zz-jason left a comment

tiancaiamao commented Sep 12, 2019

zz-jason left a comment

sre-bot commented Sep 12, 2019

sre-bot commented Sep 12, 2019

*: upgrade grpc to 1.23.0 #12055

*: upgrade grpc to 1.23.0 #12055

Conversation

lysu commented Sep 5, 2019 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

lysu commented Sep 5, 2019

lysu commented Sep 5, 2019

sre-bot commented Sep 5, 2019

sre-bot commented Sep 5, 2019

codecov bot commented Sep 6, 2019 • edited Loading

Codecov Report

lysu commented Sep 6, 2019

sre-bot commented Sep 6, 2019

sre-bot commented Sep 6, 2019

zimulala Sep 6, 2019

Choose a reason for hiding this comment

lysu Sep 10, 2019

Choose a reason for hiding this comment

lysu commented Sep 10, 2019

tiancaiamao left a comment

Choose a reason for hiding this comment

tiancaiamao Sep 11, 2019

Choose a reason for hiding this comment

zz-jason left a comment

Choose a reason for hiding this comment

tiancaiamao commented Sep 12, 2019

zz-jason left a comment

Choose a reason for hiding this comment

sre-bot commented Sep 12, 2019

sre-bot commented Sep 12, 2019

lysu commented Sep 5, 2019 •

edited

Loading

codecov bot commented Sep 6, 2019 •

edited

Loading