Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: fix go mod tidy in Go1.13 (12055) #12560

Merged
merged 4 commits into from
Oct 9, 2019
Merged

*: fix go mod tidy in Go1.13 (12055) #12560

merged 4 commits into from
Oct 9, 2019

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Oct 9, 2019 •
edited
Loading

I find go mod tidy fail on release-3.0 if I use Go 1.13:

➜  tidb git:(cherry-clean-up) go mod tidy
go: downloading gopkg.in/stretchr/testify.v1 v1.4.0
github.com/pingcap/tidb/ddl imports
	github.com/twinj/uuid tested by
	github.com/twinj/uuid.test imports
	gopkg.in/stretchr/testify.v1/assert: cannot find module providing package gopkg.in/stretchr/testify.v1/assert

Our CI environment has upgraded the Go compiler to Go 1.13 @leoppro

@tiancaiamao tiancaiamao mentioned this pull request Oct 9, 2019
Merged
@lysu
Copy link
Contributor

lysu commented Oct 9, 2019 •
edited
Loading

@tiancaiamao we need to add release note and let dba notice incompatible problem.

and next 3.0 need upgrade pump first, then upgrade TiDB.

see binlog issue:
pingcap/tidb-binlog#753
pingcap/tidb-binlog#756

and grpc incompatible PR:
grpc/grpc-go#2406

the question is: pump using cmux to proxy grpc and http, but new grpc's handshake need change the usage of cmux, so pump need upgrade to new code.

/cc @july2993

@lysu
Copy link
Contributor

lysu commented Oct 9, 2019

@tiancaiamao maybe we can only change github.com/twinj/uuid and don't upgrade grpc?

@tiancaiamao
Copy link
Contributor Author

Well, If I can solve the failed CI in #12417, I don't need this PR.

@tiancaiamao
Copy link
Contributor Author

I've reset the grpc changes

@tiancaiamao tiancaiamao changed the title *: upgrade grpc to 1.23.0 (12055) *: fix go mod tidy in Go1.13 (12055) Oct 9, 2019
@tiancaiamao
Copy link
Contributor Author

/run-all-tests

@tiancaiamao
Copy link
Contributor Author

/run-sqllogic-test tidb-test=pr/908

@tiancaiamao
Copy link
Contributor Author

/run-common-test tidb-test=pr/908

@tiancaiamao
Copy link
Contributor Author

/run-integration-compatibility-test tidb-test=pr/908

@tiancaiamao
Copy link
Contributor Author

/run-integration-common-test tidb-test=pr/908

@tiancaiamao
Copy link
Contributor Author

/run-all-tests tidb-test=pr/908

1 similar comment
@tiancaiamao
Copy link
Contributor Author

/run-all-tests tidb-test=pr/908

lysu
lysu previously approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Contributor Author

/run-all-tests tidb-test=pr/908

coocood
coocood approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood coocood merged commit 54b2bfa into pingcap:release-3.0 Oct 9, 2019
@sre-bot sre-bot mentioned this pull request Oct 9, 2019
Closed
@sre-bot
Copy link
Contributor

sre-bot commented Oct 9, 2019

cherry pick to release-3.0 in PR #12574

@tiancaiamao tiancaiamao deleted the upgrade-grpc-cherry branch October 9, 2019 08:11
tiancaiamao added a commit to tiancaiamao/tidb that referenced this pull request Oct 9, 2019
@tiancaiamao
*: fix go mod tidy in Go1.13 (12055) (pingcap#12560)
b17a8b0
@tiancaiamao tiancaiamao mentioned this pull request Oct 9, 2019
Merged
sre-bot pushed a commit that referenced this pull request Oct 9, 2019
@tiancaiamao @sre-bot
*: fix go mod tidy in Go1.13 (12055) (#12560) (#12577)
a8d93e5
@tiancaiamao tiancaiamao mentioned this pull request Oct 10, 2019
Merged
zimulala pushed a commit to zimulala/tidb that referenced this pull request Oct 10, 2019
@tiancaiamao @zimulala
*: fix go mod tidy in Go1.13 (12055) (pingcap#12560)
c91b08d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coocood coocood coocood approved these changes

@lysu lysu lysu left review comments

Assignees
No one assigned
Labels
component/tikv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiancaiamao @lysu @sre-bot @coocood