Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: deep copy the string when setting user variable from Chunk (#11041) #11044

Merged
merged 5 commits into from
Jul 9, 2019

Conversation

zz-jason
Copy link
Member

@zz-jason zz-jason commented Jul 3, 2019

cherry-pick #11041 to release-3.0

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 3, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@zz-jason
Copy link
Member Author

zz-jason commented Jul 3, 2019

/run-all-tests

1 similar comment
@qw4990
Copy link
Contributor

qw4990 commented Jul 3, 2019

/run-all-tests

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@zz-jason zz-jason requested review from XuHuaiyu and qw4990 July 6, 2019 05:00
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 9, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@zz-jason zz-jason merged commit a5a0596 into pingcap:release-3.0 Jul 9, 2019
@zz-jason zz-jason deleted the 3.0-deepcopy-for-setvar branch July 9, 2019 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants