expression: deep copy the string when assigning it to a user variable #11041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhang Jian <[email protected]>
zz-jason
added
type/bugfix
zz-jason
changed the title
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #11041 +/- ##
================================================
- Coverage 80.9612% 80.9394% -0.0218%
================================================
Files 419 419
Lines 89302 89305 +3
================================================
- Hits 72300 72283 -17
- Misses 11769 11784 +15
- Partials 5233 5238 +5 |
zz-jason
added a commit
to zz-jason/tidb
that referenced
this pull request
Jul 3, 2019
zz-jason
added a commit
to zz-jason/tidb
that referenced
this pull request
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zhang Jian [email protected]
What problem does this PR solve?
At present, the builtin
SetVarfunction might refer to the content of an underlying Chunk. The problem is, when the content of that Chunk is changed, the value of the corresponding user variable is changed as well.What is changed and how it works?
To address this issue, we should make a deep copy of that string value before assigning it to a user variable.
Check List
Tests
Related changes