privilege,executor: update DBIsVisible() function for RBAC #10261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`USE DB` check privileges using the DBIsVisible function, that function should take role into consideration CREATE DATABASE app_db CREATE ROLE 'app_developer' GRANT ALL ON app_db.* TO 'app_developer CREATE USER 'dev'@'localhost GRANT 'app_developer' TO 'dev'@'localhost' SET DEFAULT ROLE 'app_developer' TO 'dev'@'localhost' login as 'dev'@'localhost' Before: mysql> use app_db ERROR 1044 (42000): Access denied for user 'dev'@'localhost' to database 'app_db' After: mysql> use app_db; Database changed
Codecov Report
@@ Coverage Diff @@
## master #10261 +/- ##
===========================================
Coverage ? 77.3838%
===========================================
Files ? 412
Lines ? 85713
Branches ? 0
===========================================
Hits ? 66328
Misses ? 14352
Partials ? 5033 |
|
/run-all-tests |
imtbkcat
reviewed
Apr 29, 2019
| if SkipWithGrant { | ||
| return true | ||
| } | ||
| mysqlPriv := p.Handle.Get() | ||
| return mysqlPriv.DBIsVisible(p.user, p.host, db) | ||
| if mysqlPriv.DBIsVisible(p.user, p.host, db) { |
There was a problem hiding this comment.
If r_1 has privilege, r_2 doesn't have, and has relationship like r_1 -> r_2 -> user, user should have privilege to visit db.
There was a problem hiding this comment.
Do you mean user has role r_2
r_2 has role r_1 ?
I think activeRoles contains both r_1 and r_2 ? @imtbkcat
There was a problem hiding this comment.
ctx.ActiveRoles just contain r_1, you could use MySQLPrivileges.FindAllRole to get r_1 and r_2.
There was a problem hiding this comment.
Done.
PTAL @imtbkcat
jackysp
added
status/all tests passed
status/LGT1
tiancaiamao
force-pushed
the
db-visible-role
branch
from
8e5e12d to
9d2a773
Compare
|
/run-all-tests |
tiancaiamao
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
login as 'dev'@'localhost'
Before:
After:
What is changed and how it works?
USE DBcheck privileges using theDBIsVisible()function, that function should takeroleinto considerationCheck List
Tests