Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: update tidb and tiflow version #823

Merged
merged 1 commit into from
Nov 22, 2024
Merged

*: update tidb and tiflow version #823

merged 1 commit into from
Nov 22, 2024

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Nov 22, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

Release note

None

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Defined2014 Defined2014 changed the title update tidb and tiflow version *: update tidb and tiflow version Nov 22, 2024
@ti-chi-bot ti-chi-bot bot added the size/XXL label Nov 22, 2024
@purelind
Copy link

/run-all-tests

1 similar comment
@purelind
Copy link

/run-all-tests

@dveeden
Copy link
Contributor

dveeden commented Nov 22, 2024

This is a duplicate of #814

Please also see #819

@Defined2014
Copy link
Contributor Author

This is a duplicate of #814

Please also see #819

I need the newest one TiDB version to support global index.

@ti-chi-bot ti-chi-bot bot added size/L and removed size/XXL labels Nov 22, 2024
mjonss
mjonss approved these changes Nov 22, 2024
View reviewed changes
Copy link

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 22, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-22 15:31:35.426500452 +0000 UTC m=+218483.046154967: ☑️ agreed by mjonss.

@ti-chi-bot ti-chi-bot bot added the approved label Nov 22, 2024
@Defined2014
Copy link
Contributor Author

/test pull-verify

@Defined2014
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dveeden, mjonss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dveeden
Copy link
Contributor

dveeden commented Nov 22, 2024

/retest

1 similar comment
@mjonss
Copy link

mjonss commented Nov 22, 2024

/retest

@mjonss
Copy link

mjonss commented Nov 22, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit d28498c into pingcap:master Nov 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjonss mjonss mjonss approved these changes

@dveeden dveeden dveeden approved these changes

Assignees
No one assigned
Labels
approved first-time-contributor lgtm release-note-none size/L skip-issue-check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Defined2014 @CLAassistant @purelind @dveeden @mjonss