-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps required to build with go1.24-27093581 #814
Conversation
See the beautiful fix in tidb. |
go.mod
Outdated
go.etcd.io/etcd/client/v3 v3.5.12 | ||
go.etcd.io/etcd/tests/v3 v3.5.12 | ||
go.uber.org/atomic v1.11.0 | ||
go.uber.org/zap v1.27.0 | ||
google.golang.org/grpc v1.62.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we upgrade it in another PR, also for github.com/BurntSushi/toml
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So for grpc and toml you want separate PR's?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I recommend keeping it single-purpose
So for grpc and toml you want separate PR's?
|
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, mjonss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #813 ref #819
Also resolves https://github.com/pingcap/tidb-tools/security/dependabot/28
What is changed and how it works?
Check List
Tests