separation startup scripts and application config from yaml files #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e-tests |
gregwebs
reviewed
Oct 26, 2018
| @@ -14,3 +14,11 @@ We truncate at 63 chars because some Kubernetes name fields are limited to this | |||
| {{- $name := default .Chart.Name .Values.nameOverride -}} | |||
| {{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" -}} | |||
| {{- end -}} | |||
|
|
|||
| {{- define "tidb-cluster.utils.template" -}} | |||
There was a problem hiding this comment.
I would like to give the template helpers generic names if they are not specific to our chart. This makes it easier to re-use them in different charts.
tennix
reviewed
Oct 29, 2018
| @@ -14,3 +14,11 @@ We truncate at 63 chars because some Kubernetes name fields are limited to this | |||
| {{- $name := default .Chart.Name .Values.nameOverride -}} | |||
| {{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" -}} | |||
| {{- end -}} | |||
|
|
|||
| {{- define "tidb-cluster.utils.template" -}} | |||
|
The pump/drainer startup script has been separated. |
|
For the configuration files, I think it's better to add the filename suffix for toml, yaml format. |
|
I've run Have you tested the templates? |
|
/run-e2e-tests |
weekface
approved these changes
Oct 30, 2018
queenliuxx
pushed a commit
to queenliuxx/tidb-operator
that referenced
this pull request
Dec 19, 2018
…ngcap#149) * separation startup scripts and application config from yaml files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.