Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
luolibin committed Oct 30, 2018
1 parent 7a01649 commit 91843ce
Show file tree
Hide file tree
Showing 10 changed files with 16 additions and 16 deletions.
2 changes: 1 addition & 1 deletion charts/tidb-cluster/templates/drainer-configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ metadata:
helm.sh/chart: {{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}
data:
drainer-config: |-
{{ tuple "config/_drainer-config.tpl" . | include "tidb-cluster.utils.template" | indent 4 }}
{{ tuple "config/_drainer-config.tpl" . | include "helm-toolkit.utils.template" | indent 4 }}
{{- end -}}
2 changes: 1 addition & 1 deletion charts/tidb-cluster/templates/drainer-statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ spec:
- /bin/sh
- -c
- |-
{{ tuple "scripts/_start_drainer.sh.tpl" . | include "tidb-cluster.utils.template" | indent 10 }}
{{ tuple "scripts/_start_drainer.sh.tpl" . | include "helm-toolkit.utils.template" | indent 10 }}
ports:
- containerPort: 8249
name: drainer
Expand Down
2 changes: 1 addition & 1 deletion charts/tidb-cluster/templates/fullbackup-cronjob.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ spec:
- /bin/sh
- -c
- |-
{{ tuple "scripts/_start_fullbackup.sh.tpl" . | include "tidb-cluster.utils.template" | indent 14 }}
{{ tuple "scripts/_start_fullbackup.sh.tpl" . | include "helm-toolkit.utils.template" | indent 14 }}
volumeMounts:
- name: savepoint-dir
mountPath: "/savepoint-dir"
Expand Down
6 changes: 3 additions & 3 deletions charts/tidb-cluster/templates/monitor-configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ metadata:
helm.sh/chart: {{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}
data:
prometheus-config: |-
{{ tuple "config/_prometheus-config.tpl" . | include "tidb-cluster.utils.template" | indent 4 }}
{{ tuple "config/_prometheus-config.tpl" . | include "helm-toolkit.utils.template" | indent 4 }}

alert-rules-config: |-
{{ tuple "config/_alert-rules-config.tpl" . | include "tidb-cluster.utils.template" | indent 4 }}
{{ tuple "config/_alert-rules-config.tpl" . | include "helm-toolkit.utils.template" | indent 4 }}

grafana-config: |-
{{ tuple "config/_grafana-config.tpl" . | include "tidb-cluster.utils.template" | indent 4 }}
{{ tuple "config/_grafana-config.tpl" . | include "helm-toolkit.utils.template" | indent 4 }}
{{- end }}
4 changes: 2 additions & 2 deletions charts/tidb-cluster/templates/pd-configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ metadata:
helm.sh/chart: {{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}
data:
startup-script: |-
{{ tuple "scripts/_start_pd.sh.tpl" . | include "tidb-cluster.utils.template" | indent 4 }}
{{ tuple "scripts/_start_pd.sh.tpl" . | include "helm-toolkit.utils.template" | indent 4 }}

config-file: |-
{{- if .Values.pd.config }}
{{ .Values.pd.config | indent 4 }}
{{- else }}
{{ tuple "config/_pd-config.tpl" . | include "tidb-cluster.utils.template" | indent 4 }}
{{ tuple "config/_pd-config.tpl" . | include "helm-toolkit.utils.template" | indent 4 }}
{{- end -}}
4 changes: 2 additions & 2 deletions charts/tidb-cluster/templates/privileged-tidb-configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ metadata:
helm.sh/chart: {{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}
data:
startup-script: |-
{{ tuple "scripts/_start_privileged_tidb.sh.tpl" . | include "tidb-cluster.utils.template" | indent 4 }}
{{ tuple "scripts/_start_privileged_tidb.sh.tpl" . | include "helm-toolkit.utils.template" | indent 4 }}

config-file: |-
{{ tuple "config/_privileged-tidb-config.tpl" . | include "tidb-cluster.utils.template" | indent 4 }}
{{ tuple "config/_privileged-tidb-config.tpl" . | include "helm-toolkit.utils.template" | indent 4 }}
{{- end }}
2 changes: 1 addition & 1 deletion charts/tidb-cluster/templates/pump-configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ metadata:
helm.sh/chart: {{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}
data:
pump-config: |-
{{ tuple "config/_pump-config.tpl" . | include "tidb-cluster.utils.template" | indent 4 }}
{{ tuple "config/_pump-config.tpl" . | include "helm-toolkit.utils.template" | indent 4 }}
{{- end -}}
2 changes: 1 addition & 1 deletion charts/tidb-cluster/templates/pump-statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ spec:
- /bin/sh
- -c
- |-
{{ tuple "scripts/_start_pump.sh.tpl" . | include "tidb-cluster.utils.template" | indent 10 }}
{{ tuple "scripts/_start_pump.sh.tpl" . | include "helm-toolkit.utils.template" | indent 10 }}
ports:
- containerPort: 8250
name: pump
Expand Down
4 changes: 2 additions & 2 deletions charts/tidb-cluster/templates/tidb-configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ metadata:
helm.sh/chart: {{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}
data:
startup-script: |-
{{ tuple "scripts/_start_tidb.sh.tpl" . | include "tidb-cluster.utils.template" | indent 4 }}
{{ tuple "scripts/_start_tidb.sh.tpl" . | include "helm-toolkit.utils.template" | indent 4 }}

config-file: |-
{{- if .Values.tidb.config }}
{{ .Values.tidb.config | indent 4 }}
{{- else }}
{{ tuple "config/_tidb-config.tpl" . | include "tidb-cluster.utils.template" | indent 4 }}
{{ tuple "config/_tidb-config.tpl" . | include "helm-toolkit.utils.template" | indent 4 }}
{{- end -}}
4 changes: 2 additions & 2 deletions charts/tidb-cluster/templates/tikv-configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ metadata:
helm.sh/chart: {{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}
data:
startup-script: |-
{{ tuple "scripts/_start_tikv.sh.tpl" . | include "tidb-cluster.utils.template" | indent 4 }}
{{ tuple "scripts/_start_tikv.sh.tpl" . | include "helm-toolkit.utils.template" | indent 4 }}

config-file: |-
{{- if .Values.tikv.config }}
{{ .Values.tikv.config | indent 4 }}
{{- else }}
{{ tuple "config/_tikv-config.tpl" . | include "tidb-cluster.utils.template" | indent 4 }}
{{ tuple "config/_tikv-config.tpl" . | include "helm-toolkit.utils.template" | indent 4 }}
{{- end -}}

0 comments on commit 91843ce

Please sign in to comment.