Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

[2.1] Cherry-pick #176 and #179 #184

Merged
merged 2 commits into from
May 9, 2019
Merged

Conversation

kennytm
Copy link
Collaborator

@kennytm kennytm commented May 8, 2019

Cherry-picks the following two PRs to 2.1.10:

@kennytm kennytm added 2.1-cherry-pick The target branch is release-2.1 status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick Cherry-pick (backport) priority/normal labels May 8, 2019
lonng and others added 2 commits May 8, 2019 23:12
@kennytm kennytm force-pushed the kennytm/cherry-pick-176-179 branch from f0a2631 to 597d236 Compare May 8, 2019 15:12
@kennytm
Copy link
Collaborator Author

kennytm commented May 8, 2019

/run-all-tests tidb=release-2.1 tikv=release-2.1 pd=release-2.1

@kennytm
Copy link
Collaborator Author

kennytm commented May 8, 2019

PTAL @GregoryIan @lonng @july2993

Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@july2993 july2993 added status/LGT1 One reviewer already commented LGTM (LGTM1) and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels May 8, 2019
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonng lonng merged commit 4d803b8 into release-2.1 May 9, 2019
@lonng lonng deleted the kennytm/cherry-pick-176-179 branch May 9, 2019 02:08
@lonng lonng added status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) and removed status/LGT1 One reviewer already commented LGTM (LGTM1) labels May 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.1-cherry-pick The target branch is release-2.1 status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) type/cherry-pick Cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants