Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

tests: removes the emoji from a test database name #179

Merged
merged 1 commit into from
May 6, 2019
Merged

tests: removes the emoji from a test database name #179

merged 1 commit into from
May 6, 2019

Conversation

kennytm
Copy link
Collaborator

@kennytm kennytm commented May 5, 2019

What problem does this PR solve?

What is changed and how it works?

Rename the database 中文庫🥳 to just 中文庫.

Check List

Tests

  • Integration test

Side effects

Related changes

  • Need to cherry-pick to the release branch

@kennytm kennytm added status/PTAL This PR is ready for review. Add this label back after committing new changes priority/unimportant type/test Changes test cases only Should Cherry-pick This PR should be cherry-picked back the previous release train labels May 5, 2019
@kennytm
tests: removes the emoji from a test database name
cab02ec 
The character is too exotic and breaks TiDB and some old git.
@kennytm kennytm force-pushed the kennytm/remove-the-emoji-from-db-name branch from 34d651c to cab02ec Compare May 5, 2019 07:59
@kennytm
Copy link
Collaborator Author

kennytm commented May 5, 2019

/run-all-tests

PTAL @july2993

@kennytm kennytm requested a review from july2993 May 5, 2019 08:46
july2993
july2993 reviewed May 5, 2019
View reviewed changes
Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added status/LGT1 One reviewer already commented LGTM (LGTM1) and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels May 5, 2019
lonng
lonng approved these changes May 6, 2019
View reviewed changes
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonng lonng added status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) and removed status/LGT1 One reviewer already commented LGTM (LGTM1) labels May 6, 2019
@lonng lonng merged commit c8ead05 into master May 6, 2019
@lonng lonng deleted the kennytm/remove-the-emoji-from-db-name branch May 6, 2019 05:41
kennytm added a commit that referenced this pull request May 8, 2019
@kennytm
tests: removes the emoji from a test database name (#179)
f0a2631 
The character is too exotic and breaks TiDB and some old git.
@kennytm kennytm removed the Should Cherry-pick This PR should be cherry-picked back the previous release train label May 8, 2019
@kennytm kennytm mentioned this pull request May 8, 2019
Merged
kennytm added a commit that referenced this pull request May 8, 2019
@kennytm
tests: removes the emoji from a test database name (#179)
597d236 
The character is too exotic and breaks TiDB and some old git.
lonng pushed a commit that referenced this pull request May 9, 2019
@kennytm @lonng
[2.1] Cherry-pick #176 and #179 (#184)
4d803b8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@july2993 july2993 july2993 left review comments

@lonng lonng lonng approved these changes

Assignees
No one assigned
Labels
status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) type/test Changes test cases only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kennytm @lonng @july2993