Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conprof): support conprof on new o11y #1607

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Oct 27, 2023

No description provided.

@ti-chi-bot ti-chi-bot bot requested a review from Renkai October 27, 2023 10:10
@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for tidb-dashboard ready!

Name Link
🔨 Latest commit 72e5eba
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/654cb49eb8da540008aa2e8e
😎 Deploy Preview https://deploy-preview-1607--tidb-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ti-chi-bot ti-chi-bot bot added the size/M label Oct 27, 2023
@baurine baurine marked this pull request as draft October 27, 2023 10:10
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #1607 (72e5eba) into master (13ee5c8) will increase coverage by 15.31%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1607       +/-   ##
===========================================
+ Coverage    9.27%   24.58%   +15.31%     
===========================================
  Files         123      169       +46     
  Lines       13007    15299     +2292     
===========================================
+ Hits         1206     3762     +2556     
+ Misses      11671    11254      -417     
- Partials      130      283      +153     
Flag Coverage Δ
backend_integration 9.27% <ø> (ø)
backend_ut 26.40% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13ee5c8...72e5eba. Read the comment docs.

@baurine baurine force-pushed the feat/conprof-for-clinic branch 2 times, most recently from 01185f1 to 31e36d1 Compare October 27, 2023 10:34
@ti-chi-bot ti-chi-bot bot added size/L and removed size/M labels Oct 27, 2023
@baurine baurine force-pushed the feat/conprof-for-clinic branch from a8edb74 to 27a48ed Compare November 7, 2023 09:04
@baurine baurine force-pushed the feat/conprof-for-clinic branch from 27a48ed to fc64357 Compare November 9, 2023 01:21
@baurine baurine force-pushed the feat/conprof-for-clinic branch from f0901fd to 72e5eba Compare November 9, 2023 10:29
@baurine baurine marked this pull request as ready for review November 9, 2023 10:50
@baurine baurine requested a review from mornyx November 9, 2023 10:50
Copy link
Contributor

ti-chi-bot bot commented Nov 9, 2023

@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mornyx
Once this PR has been reviewed and has the lgtm label, please ask for approval from baurine. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@baurine baurine merged commit 6d4edea into master Nov 9, 2023
@baurine baurine deleted the feat/conprof-for-clinic branch November 9, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants