feat(conprof): refine

pingcap · Nov 9, 2023 · f0901fd · f0901fd
1 parent 9ad3206
commit f0901fd
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 13 deletions.
diff --git a/ui/packages/tidb-dashboard-for-clinic-cloud/src/apps/ContinuousProfiling/context.ts b/ui/packages/tidb-dashboard-for-clinic-cloud/src/apps/ContinuousProfiling/context.ts
@@ -92,8 +92,6 @@ export const ctx: (
   cfg: {
     apiPathBase: client.getBasePath(),
     publicPathBase,
-    checkNgm: true,
-    showSetting: true,
     ...cfg
   }
 })
diff --git a/ui/packages/tidb-dashboard-for-op/src/apps/ContinuousProfiling/context.ts b/ui/packages/tidb-dashboard-for-op/src/apps/ContinuousProfiling/context.ts
@@ -88,9 +88,6 @@ export const ctx: IConProfilingContext = {
   ds,
   cfg: {
     apiPathBase: client.getBasePath(),
-    publicPathBase,
-    checkNgm: true,
-    showSetting: true,
-    listDuration: 2
+    publicPathBase
   }
 }
diff --git a/ui/packages/tidb-dashboard-lib/src/apps/ContinuousProfiling/context/index.ts b/ui/packages/tidb-dashboard-lib/src/apps/ContinuousProfiling/context/index.ts
@@ -60,14 +60,13 @@ export interface IConProfilingDataSource {
 
 export interface IConProfilingConfig extends IContextConfig {
   publicPathBase: string
-  checkNgm: boolean
 
-  showSetting: boolean
+  checkNgm?: boolean // default value is true
+  showSetting?: boolean // default value is true
   enableDownloadGroup?: boolean // default value is true
   enableDotGraph?: boolean // default value is true
   enablePreviewGoroutine?: boolean // default value is true
-
-  listDuration?: number // unit hour, 1 means 1 hour, 2 means 2 hours
+  listDuration?: number // unit hour, 1 means 1 hour, 2 means 2 hours, default value is 2 hours
 }
 
 export interface IConProfilingContext {

diff --git a/ui/packages/tidb-dashboard-lib/src/apps/ContinuousProfiling/index.tsx b/ui/packages/tidb-dashboard-lib/src/apps/ContinuousProfiling/index.tsx
@@ -14,13 +14,14 @@ addTranslations(translations)
 function AppRoutes() {
   useLocationChange()
   const ctx = useContext(ConProfilingContext)
+  const checkNgm = ctx?.cfg.checkNgm ?? true
 
   return (
     <Routes>
       <Route
         path="/continuous_profiling"
         element={
-          ctx?.cfg.checkNgm ? (
+          checkNgm ? (
             <NgmNotStartedGuard>
               <List />
             </NgmNotStartedGuard>
@@ -32,7 +33,7 @@ function AppRoutes() {
       <Route
         path="/continuous_profiling/detail"
         element={
-          ctx?.cfg.checkNgm ? (
+          checkNgm ? (
             <NgmNotStartedGuard>
               <ParamsPageWrapper>
                 <Detail />

diff --git a/ui/packages/tidb-dashboard-lib/src/apps/ContinuousProfiling/pages/List.tsx b/ui/packages/tidb-dashboard-lib/src/apps/ContinuousProfiling/pages/List.tsx
@@ -37,6 +37,7 @@ import { useURLTimeRange } from '@lib/hooks/useURLTimeRange'
 
 export default function Page() {
   const ctx = useContext(ConProfilingContext)
+  const showSetting = ctx?.cfg.showSetting ?? true
   const durationHour = ctx?.cfg.listDuration ?? 2
 
   const { timeRange, setTimeRange } = useURLTimeRange()
@@ -257,7 +258,7 @@ export default function Page() {
                 <ReloadOutlined onClick={refresh} />
               )}
             </Tooltip>
-            {ctx?.cfg.showSetting && (
+            {showSetting && (
               <Tooltip
                 mouseEnterDelay={0}
                 mouseLeaveDelay={0}