Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiling: Add the support for TiKV heap profiling #1600

Merged
merged 13 commits into from
Oct 30, 2023

Conversation

Connor1996
Copy link
Member

@Connor1996 Connor1996 commented Oct 11, 2023

With tikv/tikv#15695, TiKV now can fetch heap profiles remotely. So add the support for TiKV heap profiling on tidb-dashboard

ENMW32RqhD

Signed-off-by: Connor1996 <[email protected]>
Signed-off-by: Connor1996 <[email protected]>
Signed-off-by: Connor1996 <[email protected]>
Signed-off-by: Connor1996 <[email protected]>
@ti-chi-bot ti-chi-bot bot requested a review from Renkai October 11, 2023 09:22
@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for tidb-dashboard ready!

Name Link
🔨 Latest commit c399665
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/653f22055509790009302032
😎 Deploy Preview https://deploy-preview-1600--tidb-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2023

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/XXL label Oct 11, 2023
Signed-off-by: Connor1996 <[email protected]>
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #1600 (c399665) into master (c6ca8cf) will decrease coverage by 0.11%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1600      +/-   ##
==========================================
- Coverage   24.71%   24.61%   -0.11%     
==========================================
  Files         169      169              
  Lines       15227    15290      +63     
==========================================
  Hits         3763     3763              
- Misses      11182    11245      +63     
  Partials      282      282              
Flag Coverage Δ
backend_integration 9.27% <0.00%> (-0.05%) ⬇️
backend_ut 26.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58f855e...c399665. Read the comment docs.

Signed-off-by: Connor1996 <[email protected]>
Signed-off-by: Connor1996 <[email protected]>
Signed-off-by: Connor1996 <[email protected]>
Signed-off-by: Connor1996 <[email protected]>
Signed-off-by: Connor1996 <[email protected]>
@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 30, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baurine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-30 03:58:53.280385909 +0000 UTC m=+2839130.867496040: ☑️ agreed by baurine.

@ti-chi-bot ti-chi-bot bot added the approved label Oct 30, 2023
@ti-chi-bot ti-chi-bot bot merged commit 9e2ba5e into pingcap:master Oct 30, 2023
baurine added a commit that referenced this pull request Nov 8, 2023
* Revert "Release v2023.11.02.1 (#1609)"

This reverts commit 865955c.

* feat(statements): show `plan_cache_hits` field (#1598)

* tweak: make the goroutine profile more verbose (#1450)

* feat: support additional OIDC parameters (#1567)

Co-authored-by: Sparkle <[email protected]>

* chore(sso): improve client secret security (#1599)

* chore(topsql): adjust TopSQL for clinic (#1601)

* chore(sso): support customize OIDC scopes (#1602)

* chore(clinic): support redirect back after login for clinic (#1603)

* chore(topsql): remove username for clinic (#1605)

* chore(topsql): show cluster name and disable auto-refresh for clinic (#1606)

* profiling: Add the support for TiKV heap profiling (#1600)

* increase the upper limit of testing time (#1526)

* fix cannot login when use ipv6 address (#1516)

* tweak: explicitly set session max_execution_time to 600s (#1608)

* profiling: reuse convertDotToSVG to generate tikv heap profile svg (#1610)

* update release version to 2023.11.08.1

---------

Co-authored-by: Yexiang Zhang <[email protected]>
Co-authored-by: horus <[email protected]>
Co-authored-by: Connor <[email protected]>
Co-authored-by: nexustar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants