Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak: make the goroutine profile more verbose #1450

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

mornyx
Copy link
Collaborator

@mornyx mornyx commented Dec 9, 2022

close #1401

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Dec 9, 2022

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2022

Codecov Report

Merging #1450 (36b8c9f) into master (5741300) will increase coverage by 3.21%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1450      +/-   ##
==========================================
+ Coverage   26.19%   29.41%   +3.21%     
==========================================
  Files         202      128      -74     
  Lines       15405    10530    -4875     
  Branches      103      103              
==========================================
- Hits         4035     3097     -938     
+ Misses      11099     7253    -3846     
+ Partials      271      180      -91     
Flag Coverage Δ
backend_integration ?
backend_ut 27.58% <ø> (ø)
e2e_test 62.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5741300...36b8c9f. Read the comment docs.

@mornyx
Copy link
Collaborator Author

mornyx commented Dec 9, 2022

/cc @YiniXu9506 PTAL, Thanks!

@mornyx mornyx changed the title Make the goroutine profile more verbose tweak: make the goroutine profile more verbose Jul 25, 2023
@ti-chi-bot ti-chi-bot bot added the size/XS label Jul 25, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 4, 2023

@jackysp: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jackysp
Copy link
Member

jackysp commented Oct 4, 2023

@baurine @breezewish @iosmanthus PTAL, thanks~

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 7, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-07 02:46:04.223343629 +0000 UTC m=+847561.810453771: ☑️ agreed by breezewish.

@ti-chi-bot ti-chi-bot bot added the approved label Oct 7, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: breezewish, jackysp, shhdgit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 38109d4 into pingcap:master Oct 7, 2023
@mornyx mornyx deleted the profile branch October 16, 2023 09:01
baurine added a commit that referenced this pull request Nov 8, 2023
* Revert "Release v2023.11.02.1 (#1609)"

This reverts commit 865955c.

* feat(statements): show `plan_cache_hits` field (#1598)

* tweak: make the goroutine profile more verbose (#1450)

* feat: support additional OIDC parameters (#1567)

Co-authored-by: Sparkle <[email protected]>

* chore(sso): improve client secret security (#1599)

* chore(topsql): adjust TopSQL for clinic (#1601)

* chore(sso): support customize OIDC scopes (#1602)

* chore(clinic): support redirect back after login for clinic (#1603)

* chore(topsql): remove username for clinic (#1605)

* chore(topsql): show cluster name and disable auto-refresh for clinic (#1606)

* profiling: Add the support for TiKV heap profiling (#1600)

* increase the upper limit of testing time (#1526)

* fix cannot login when use ipv6 address (#1516)

* tweak: explicitly set session max_execution_time to 600s (#1608)

* profiling: reuse convertDotToSVG to generate tikv heap profile svg (#1610)

* update release version to 2023.11.08.1

---------

Co-authored-by: Yexiang Zhang <[email protected]>
Co-authored-by: horus <[email protected]>
Co-authored-by: Connor <[email protected]>
Co-authored-by: nexustar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make the profile result more readable
7 participants