feat(security): encrypt login password #1583
Conversation
✅ Deploy Preview for tidb-dashboard ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1583 +/- ##
==========================================
+ Coverage 24.65% 26.42% +1.77%
==========================================
Files 168 97 -71
Lines 15142 10443 -4699
==========================================
- Hits 3733 2760 -973
+ Misses 11135 7498 -3637
+ Partials 274 185 -89
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
baurine
force-pushed
the
feat/encrypt-pwd
branch
from
19c68d2 to
5bc13ef
Compare
baurine
force-pushed
the
feat/encrypt-pwd
branch
from
2b93907 to
9ebe316
Compare
baurine
changed the title
|
Backend LGTM. BTW, Should we provide a configuration item for this feature (maybe disabled by default), rather than as the only choice? |
|
@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mornyx, shhdgit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
After we can encrypt the login password, I don't think the user want to see the plain password again. |
* feat(execution-plan): refine execution plan (#1561) * chore(binary-plan): truncate long operator info for execution plan (#1565) * feat: fix and refine execution plan (#1568) * chore(binary-plan): show eye icon to hide column when hover (#1574) * bump: i18next (#1575) * Remove PNPM_INSTALL_TAGS=--offline (#1578) * chore: upgrade node from 16 to 18, pnpm from 7 to 8 (#1580) * feat(conprof): show conprof download link for TiCDC (#1581) * keyvisual: use scanRegions instead of fetch all regions (#1579) * feat(resource-control): show resource control entry for clinic (#1582) * feat(debug-api): support pagination for ddl history (#1584) * feat(security): encrypt login password (#1583) * chore: update swaggo (#1585) * test(login): fix login integration test (#1587) * update release version to 2023.09.11.1 --------- Co-authored-by: Suhaha <[email protected]> Co-authored-by: Yifan Xu <[email protected]> Co-authored-by: ShuNing <[email protected]> Co-authored-by: Yexiang Zhang <[email protected]>
What Did
Encrypt the SQL Auth password in the frontend side by the RSA public key, and decrypt it in the backend side.
Preview