-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keyvisual: use scanRegions instead of fetch all regions #1579
Conversation
✅ Deploy Preview for tidb-dashboard ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❌ Deploy Preview for tidb-dashboard-for-dbaas failed.
|
Signed-off-by: nolouch <[email protected]>
84c80b6
to
8c44f55
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1579 +/- ##
==========================================
- Coverage 24.68% 24.61% -0.07%
==========================================
Files 168 168
Lines 15097 15135 +38
==========================================
Hits 3726 3726
- Misses 11097 11135 +38
Partials 274 274
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[LGTM Timeline notifier]Timeline:
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baurine, mornyx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* feat(execution-plan): refine execution plan (#1561) * chore(binary-plan): truncate long operator info for execution plan (#1565) * feat: fix and refine execution plan (#1568) * chore(binary-plan): show eye icon to hide column when hover (#1574) * bump: i18next (#1575) * Remove PNPM_INSTALL_TAGS=--offline (#1578) * chore: upgrade node from 16 to 18, pnpm from 7 to 8 (#1580) * feat(conprof): show conprof download link for TiCDC (#1581) * keyvisual: use scanRegions instead of fetch all regions (#1579) * feat(resource-control): show resource control entry for clinic (#1582) * feat(debug-api): support pagination for ddl history (#1584) * feat(security): encrypt login password (#1583) * chore: update swaggo (#1585) * test(login): fix login integration test (#1587) * update release version to 2023.09.11.1 --------- Co-authored-by: Suhaha <[email protected]> Co-authored-by: Yifan Xu <[email protected]> Co-authored-by: ShuNing <[email protected]> Co-authored-by: Yexiang Zhang <[email protected]>
If deploy tidb-dashboard independently, key visual will use pd API to fetch regions. here is an improvement about it.
PD memory:
before
after
test with new apis: