Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add graph generation #1085

Merged
merged 17 commits into from
Dec 14, 2021

Conversation

YiniXu9506
Copy link
Contributor

@YiniXu9506 YiniXu9506 commented Dec 6, 2021

This PR achieved:

  1. supporting view graph of CPU profiling online.
  2. making previous generated SVG files viewable online.
  3. adding multi profiling output types for user to choose by using button with dropdown menu.

The previous generated SVG can only view the Graph or Flame Graph:
image

User can view Graph, Flame Graph and download raw data of a single instance:
image

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 6, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breeswish

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@breezewish
Copy link
Member

breezewish commented Dec 6, 2021

As the first impression I have two ideas:

  1. You may want to use a button with dropdown menu, instead of a dropdown and a menu, to eliminate one click:

    image

    doc: https://ant.design/components/button-cn/

    Possible menu labels can be:

    Action
    ----------------
    View Flame Graph | v
                View Dot Graph
                Download Raw Data
    

    BTW as there are many menus in the table, you should not mark these menus to have a "default" (blue) style. It should be a normal button without blue background.

  2. Seems that the table row is no longer vertically aligned. Could you fix it?

pkg/apiserver/profiling/protobuf_to_svg.go Outdated Show resolved Hide resolved
pkg/apiserver/profiling/router.go Outdated Show resolved Hide resolved
ui/lib/apps/InstanceProfiling/pages/Detail.tsx Outdated Show resolved Hide resolved
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest LGTM. @baurine @shhdgit PTAL

pkg/apiserver/profiling/router.go Outdated Show resolved Hide resolved
ui/lib/apps/InstanceProfiling/pages/Detail.tsx Outdated Show resolved Hide resolved
ui/lib/apps/InstanceProfiling/pages/Detail.tsx Outdated Show resolved Hide resolved
ui/lib/apps/InstanceProfiling/pages/Detail.tsx Outdated Show resolved Hide resolved
ui/lib/apps/InstanceProfiling/pages/Detail.tsx Outdated Show resolved Hide resolved
pkg/apiserver/profiling/router.go Outdated Show resolved Hide resolved
ui/lib/apps/InstanceProfiling/pages/Detail.tsx Outdated Show resolved Hide resolved
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM

pkg/apiserver/profiling/model.go Outdated Show resolved Hide resolved
pkg/apiserver/profiling/model.go Outdated Show resolved Hide resolved
pkg/apiserver/profiling/router.go Outdated Show resolved Hide resolved
ui/lib/apps/InstanceProfiling/pages/Detail.tsx Outdated Show resolved Hide resolved
ui/lib/apps/InstanceProfiling/pages/Detail.tsx Outdated Show resolved Hide resolved
ui/lib/apps/InstanceProfiling/pages/Detail.tsx Outdated Show resolved Hide resolved
ui/lib/apps/InstanceProfiling/pages/Detail.tsx Outdated Show resolved Hide resolved
ui/lib/apps/InstanceProfiling/pages/Detail.tsx Outdated Show resolved Hide resolved
ui/lib/apps/InstanceProfiling/pages/Detail.tsx Outdated Show resolved Hide resolved
@breezewish
Copy link
Member

@baurine @shhdgit PTAL

Copy link
Member

@shhdgit shhdgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@breezewish
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a064e90

@ti-chi-bot ti-chi-bot merged commit f332a04 into pingcap:master Dec 14, 2021
@YiniXu9506 YiniXu9506 deleted the support_profiling_graph branch December 14, 2021 02:15
baurine pushed a commit to baurine/tidb-dashboard that referenced this pull request Dec 30, 2021
baurine added a commit that referenced this pull request Dec 30, 2021
* Revert "Release v2021.12.06.1 (#1084)"

This reverts commit bcc43a0.

* Compitable with different TiDB versions for conprof and non-root-login features (#1047)

* make conprof independent

* check feature enable

* add check feature enable middleware

* hide menu if feature is not enabled

* refactor non root login switch by new design

* i18n

* yarn fmt

* renaming

* adjust fe code

* refine

* remove unused log

* build(deps): bump ws from 5.2.2 to 5.2.3 in /ui (#1055)

* CICD: Update the release pipeline for recent PD format policies (#1054)

* fix i18n wording (#1056)

* Refactor: Change util module to util package (#1052)

* Refactor: Fix godot incorrectly add dot suffix to annotations (#1059)

* lint: Add goheader for copyright lints (#1062)

* Refactor: Migrate to use the `rest` package in util/ (#1060)

* fix(*): globally delete/update data by GORM (#1065)

* ui: bump dependencies (#1066)

* refactor: Switch to use ziputil, netutil, reflectutil and fileswap (#1067)

* Fix request header being pinned after pd profiling (#1069)

* Integrate speedscope (#1064)

* fix potential panic when GetPDInstances (#1075)

Signed-off-by: crazycs <[email protected]>

* Refactor: a new httpclient (#1073)

* Refactor: Switch to use util/distro in all places (#1078)

* chore: support import relative file URL (#1082)

* Refactor: Move tools into a standalone module (#1079)

* Fix script to embed the ui (#1088)

* Fix script to embed the ui

* Hack write_strings

* Refactor feature flag to support more modules (#1057)

* Drop sysutil dependency (#1093)

* chore: add graph generation (#1085)

* Refactor: Add TopologyProvider (#1098)

* esbuild: i18n + dep (#1101)

* script: Add a script to generate version matrix (#1104)

* distro: support dynamic config (#1094)

* chore: support multiple profiling types (#1095)

* fix(distro): check distro_strings.json fmt by prettier (#1106)

* script: fix generate assets (#1107)

* Add integration test (#1083)

* debug_api: Switch to use the new util (#1103)

* refactor(ui): auto refresh button (#1105)

* refactor(ui): auto refresh button

* chore: update translation

* fix: remain seconds

* refine: refresh button

* fix: onRefresh

* fix: auto refresh

* fix: continue tick

* chore: add some comments

* tweak: remaining refresh seconds

* chore: clean code

Co-authored-by: Wenxuan <[email protected]>

* ui: refine conprof (#1102)

* update wording

* not check prom any more

* replace time range component

* i18n

* support view profile by diffrent ways

* extract ActionsButton

* change download data format

* refine

* comments

* Revert "comments"

This reverts commit 3b03fdb.

* fix view cpu profile fail

* update state

* hide action button if disable

* address feedback

* update release-version

* sync with master

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wenxuan <[email protected]>
Co-authored-by: Suhaha <[email protected]>
Co-authored-by: Yini Xu <[email protected]>
Co-authored-by: crazycs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants