fix(*): globally delete/update data by GORM #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
shhdgit
force-pushed
the
fix/keyviz-global-del
branch
2 times, most recently
from
5701ab1 to
bcbedca
Compare
shhdgit
changed the title
shhdgit
changed the title
shhdgit
changed the title
shhdgit
force-pushed
the
fix/keyviz-global-del
branch
from
bcbedca to
af9a798
Compare
|
There are no more global delete/update ORM functions. |
breezewish
approved these changes
Nov 19, 2021
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: af9a798
|
|
@shhdgit Please follow up the creation of PD PR for this bug fix. Thanks! We should carry this fix to releases from PD 4.0.x to latest. |
shhdgit
added a commit
to shhdgit/tidb-dashboard
that referenced
this pull request
Nov 25, 2021
shhdgit
added a commit
to shhdgit/tidb-dashboard
that referenced
this pull request
Nov 25, 2021
shhdgit
added a commit
that referenced
this pull request
Dec 1, 2021
Closed
shhdgit
added a commit
to shhdgit/tidb-dashboard
that referenced
this pull request
Dec 1, 2021
baurine
pushed a commit
to baurine/tidb-dashboard
that referenced
this pull request
Dec 30, 2021
baurine
added a commit
that referenced
this pull request
Dec 30, 2021
* Revert "Release v2021.12.06.1 (#1084)" This reverts commit bcc43a0. * Compitable with different TiDB versions for conprof and non-root-login features (#1047) * make conprof independent * check feature enable * add check feature enable middleware * hide menu if feature is not enabled * refactor non root login switch by new design * i18n * yarn fmt * renaming * adjust fe code * refine * remove unused log * build(deps): bump ws from 5.2.2 to 5.2.3 in /ui (#1055) * CICD: Update the release pipeline for recent PD format policies (#1054) * fix i18n wording (#1056) * Refactor: Change util module to util package (#1052) * Refactor: Fix godot incorrectly add dot suffix to annotations (#1059) * lint: Add goheader for copyright lints (#1062) * Refactor: Migrate to use the `rest` package in util/ (#1060) * fix(*): globally delete/update data by GORM (#1065) * ui: bump dependencies (#1066) * refactor: Switch to use ziputil, netutil, reflectutil and fileswap (#1067) * Fix request header being pinned after pd profiling (#1069) * Integrate speedscope (#1064) * fix potential panic when GetPDInstances (#1075) Signed-off-by: crazycs <[email protected]> * Refactor: a new httpclient (#1073) * Refactor: Switch to use util/distro in all places (#1078) * chore: support import relative file URL (#1082) * Refactor: Move tools into a standalone module (#1079) * Fix script to embed the ui (#1088) * Fix script to embed the ui * Hack write_strings * Refactor feature flag to support more modules (#1057) * Drop sysutil dependency (#1093) * chore: add graph generation (#1085) * Refactor: Add TopologyProvider (#1098) * esbuild: i18n + dep (#1101) * script: Add a script to generate version matrix (#1104) * distro: support dynamic config (#1094) * chore: support multiple profiling types (#1095) * fix(distro): check distro_strings.json fmt by prettier (#1106) * script: fix generate assets (#1107) * Add integration test (#1083) * debug_api: Switch to use the new util (#1103) * refactor(ui): auto refresh button (#1105) * refactor(ui): auto refresh button * chore: update translation * fix: remain seconds * refine: refresh button * fix: onRefresh * fix: auto refresh * fix: continue tick * chore: add some comments * tweak: remaining refresh seconds * chore: clean code Co-authored-by: Wenxuan <[email protected]> * ui: refine conprof (#1102) * update wording * not check prom any more * replace time range component * i18n * support view profile by diffrent ways * extract ActionsButton * change download data format * refine * comments * Revert "comments" This reverts commit 3b03fdb. * fix view cpu profile fail * update state * hide action button if disable * address feedback * update release-version * sync with master Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wenxuan <[email protected]> Co-authored-by: Suhaha <[email protected]> Co-authored-by: Yini Xu <[email protected]> Co-authored-by: crazycs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because gorm upgraded to v2 by #916 and gorm@v2 was BlockGlobalUpdate by default. https://gorm.io/docs/v2_release_note.html#BlockGlobalUpdate
We will get a
ErrMissingWhereClauseerror when we globally update/delete data: