This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
backup: dump stats to json should not be fatal #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
force-pushed
the
skip-broken-stats
branch
2 times, most recently
from
890b526 to
3b2d529
Compare
also improved some logs
kennytm
force-pushed
the
skip-broken-stats
branch
from
3b2d529 to
df4930d
Compare
ti-srebot
approved these changes
Jan 8, 2021
|
/merge |
|
/run-all-tests |
|
@kennytm merge failed. |
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/br
that referenced
this pull request
Jan 11, 2021
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #686 |
ti-srebot
pushed a commit
to ti-srebot/br
that referenced
this pull request
Jan 11, 2021
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-5.0-rc in PR #687 |
lichunzhu
pushed a commit
that referenced
this pull request
Jan 11, 2021
Signed-off-by: ti-srebot <[email protected]> Co-authored-by: kennytm <[email protected]>
kennytm
added a commit
that referenced
this pull request
Jan 12, 2021
Signed-off-by: ti-srebot <[email protected]> Co-authored-by: kennytm <[email protected]> Co-authored-by: Neil Shen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also improved some logs
What problem does this PR solve?
Part 1 of #679.
What is changed and how it works?
If the stats is broken, we just log and skip it instead of bailing out.
Check List
Tests
Code changes
Side effects
Related changes
Release Note