This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
backup: dump stats to json should not be fatal (#682) #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <[email protected]>
|
/run-all-tests |
2 similar comments
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
LGTM |
|
/merge |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
(Hound is broken) |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
kennytm
approved these changes
Jan 12, 2021
ti-srebot
added
status/LGT3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #682 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In br repo: git pr 686After apply modifications, you can push your change to this PR via:
also improved some logs
What problem does this PR solve?
Part 1 of #679.
What is changed and how it works?
If the stats is broken, we just log and skip it instead of bailing out.
Check List
Tests
Code changes
Side effects
Related changes
Release Note