Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inky Frame: longer sleep_for #754

Merged
merged 3 commits into from
May 4, 2023
Merged

Conversation

ahnlak
Copy link
Contributor

@ahnlak ahnlak commented Apr 21, 2023

Expanded sleep_for() function to allow for sleeps longer than 24 hours - by adding the day component to the alarm, this maximum can be stretched to a month (capped at 28 days)

I've validated the code as best I can, but I don't actually possess an Inky Frame myself :-)

ref: #744

@Gadgetoid
Copy link
Member

Thank you. Something weird has happened to the Cosmic Unicorn build here- with undefined references across a bunch of things that should not be referenced 😬 - looking into it!

@ahnlak
Copy link
Contributor Author

ahnlak commented Apr 24, 2023

I saw all those errors and decided they probably weren't my fault :)

@Gadgetoid
Copy link
Member

Hoookay, I think I've found the cache bugs. If you can rebase this it might just pass CI 😭

@Gadgetoid
Copy link
Member

Hooray! This should also work for Badger 2040 W, which has the same function here: https://github.com/pimoroni/badger2040/blob/main/firmware/PIMORONI_BADGER2040W/lib/badger2040.py#L133-L154

@ahnlak
Copy link
Contributor Author

ahnlak commented Apr 24, 2023

Is that a request? ;-)

@Gadgetoid
Copy link
Member

Let's call it a reminder 😆

@Gadgetoid Gadgetoid merged commit a59aa35 into pimoroni:main May 4, 2023
@ahnlak ahnlak deleted the if_longer_sleep_for branch August 31, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants