Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for non-vendored abseil and googletest #18

Open
timkpaine opened this issue Sep 13, 2023 · 4 comments
Open

Allow for non-vendored abseil and googletest #18

timkpaine opened this issue Sep 13, 2023 · 4 comments

Comments

@timkpaine
Copy link
Contributor

Many registries don't like it when you vendor third party, so we should make these opt-out.

ref: Homebrew/homebrew-core#142146 (comment)

@pieter3d
Copy link
Owner

I don't follow, what does it mean to "vendor" third_party?

@timkpaine
Copy link
Contributor Author

I can do this so no worries, but basically don't require git submodules, instead either be entirely self contained or otherwise able to pull from the user's existing installed libraries.

@pieter3d
Copy link
Owner

I see. Submodules seem like a nice solution though. If you rely on a user's local install, you can have all kinds of random compilation issues. Surelog itself is full of submodules too.

@timkpaine
Copy link
Contributor Author

Most registries don't want this type of thing. Surelog doesn't require any submodules either, it will happily pull them from your outer environment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants