Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simview v0.1 (new formula) #142146

Closed
wants to merge 1 commit into from
Closed

simview v0.1 (new formula) #142146

wants to merge 1 commit into from

Conversation

timkpaine
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

FYI @pieter3d

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Sep 13, 2023
@timkpaine timkpaine marked this pull request as ready for review September 13, 2023 03:51
Formula/s/simview.rb Show resolved Hide resolved
Formula/s/simview.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. and removed autosquash Automatically squash pull request commits according to Homebrew style. labels Sep 14, 2023
@SMillerDev SMillerDev removed their request for review September 29, 2023 10:30
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Oct 21, 2023
@timkpaine
Copy link
Contributor Author

needs: chipsalliance/Surelog#3913 and new release

@github-actions github-actions bot removed the stale No recent activity label Oct 21, 2023
@timkpaine
Copy link
Contributor Author

all set again

Formula/s/simview.rb Outdated Show resolved Hide resolved
Co-authored-by: Sean Molenaar <[email protected]>
@fxcoudert
Copy link
Member

At this stage, given the difficulties and number of things that need to be upstreamed to clean up the build, as well as the fact that this is a first release (0.1), I think we should wait for a future release with the issues fixed and simpler installation.

@fxcoudert
Copy link
Member

I am going to close this pull request. Of course, we would be happy to reconsider in the future, when the issues are address.

In the meantime, you can also host it in a personal tap, which is very easy to do: https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap

@fxcoudert fxcoudert closed this Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants