Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve scale/orientation of scene input #56

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Preserve scale/orientation of scene input #56

merged 2 commits into from
Mar 22, 2024

Conversation

pierotofy
Copy link
Owner

@pierotofy pierotofy commented Mar 22, 2024

Closes #34

We achieve this by preserving the original scene rotation and training on a translated/scaled version and subsequently restoring translation/scale.

@pierotofy
Copy link
Owner Author

pierotofy commented Mar 22, 2024

One downside is that some viewers will not automatically center to the model (they expect the scene to be at [0,0,0]). If this becomes an issue we can add a flag for optionally keeping the centered orientation.

@pierotofy pierotofy merged commit 521121d into main Mar 22, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore original camera orientation, scale when saving scene
1 participant