Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore original camera orientation, scale when saving scene #34

Closed
pierotofy opened this issue Mar 6, 2024 · 3 comments · Fixed by #56
Closed

Restore original camera orientation, scale when saving scene #34

pierotofy opened this issue Mar 6, 2024 · 3 comments · Fixed by #56
Labels
enhancement New feature or request

Comments

@pierotofy
Copy link
Owner

During training the model is scaled and oriented.

Before outputting the output PLY, we should scale / rotate the scene back to its original CRS.

@pierotofy pierotofy added the enhancement New feature or request label Mar 6, 2024
@pfxuan
Copy link
Collaborator

pfxuan commented Mar 7, 2024

To reserve the metric scale and camera orientation, it might be easier to feed the original sparse point cloud to training code directly. Rotating the trained ply model file would introduce an extra complicity and quality degradation if it's not handled correctly.

@pierotofy
Copy link
Owner Author

@pfxuan
Copy link
Collaborator

pfxuan commented Mar 14, 2024

Yes, PlayCanvas's implementation works almost faultlessly. It would be even better if OpenSplat can use the compressed ply format as one of saving options along with the rotation and scaling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants