Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that the router does not always have to be the DHCP server #967

Merged
merged 1 commit into from
Jun 16, 2019

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jun 15, 2019

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Fixes #893

How does this PR accomplish the above?:

Improve wording as suggested in the referenced issue ticket.

What documentation changes (if any) are needed to support this PR?:

None

@DL6ER DL6ER added this to the v5.0 milestone Jun 15, 2019
@DL6ER DL6ER requested a review from a team June 15, 2019 15:48
@AzureMarker AzureMarker merged commit 91c9865 into devel Jun 16, 2019
@AzureMarker AzureMarker deleted the fix/clarify_advanced_dns_settings_text branch June 16, 2019 04:20
AzureMarker added a commit that referenced this pull request Sep 11, 2019
…s_text

Clarify that the router does not always have to be the DHCP server
@AzureMarker AzureMarker modified the milestones: v5.0, v4.3.2 Sep 12, 2019
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-4-3-2-release-notes/23852/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants