-
-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong text/suggestion in Advanced DNS settings #893
Comments
Open a PR for this change, it looks good. The "likely found within the DHCP settings" part could also get removed since it's already talking about the DHCP server settings. |
Text is in |
I disagree. The vast majority of users install it in their home networks which have the most simple topology you can imagine (devices connected to a router). Nevertheless, your suggested change is good. |
…ixes #893 Signed-off-by: DL6ER <[email protected]>
…ixes #893 Signed-off-by: DL6ER <[email protected]>
In raising this issue, I confirm the following:
{please fill the checkboxes, e.g: [X]}
How familiar are you with the the source code relevant to this issue?:
{1}
Expected behaviour:
{Pi-hole should use conditional forwarding from the DHCP server.}
Actual behaviour:
{There is asked to fill in the address of the router, what isn't the same}
Troubleshooting undertaken, and/or other relevant information:
{Steps of what you have done to fix this}
The text under Advanced DNS settings, Conditional Forwarding should ask to fill in the address and local domain of the DHCP server.
This could be the Router, but in a lot of cases this isn't the router.
The text now is:
And should be:
The text was updated successfully, but these errors were encountered: