Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace fa-refresh with fa-sync #942

Merged
merged 1 commit into from
May 19, 2019
Merged

Replace fa-refresh with fa-sync #942

merged 1 commit into from
May 19, 2019

Conversation

AzureMarker
Copy link
Contributor

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:
Fix #941

How does this PR accomplish the above?:
Font Awesome 5 replaced the refresh icon from 4 with fa-sync:
https://fontawesome.com/how-to-use/on-the-web/setup/upgrading-from-version-4#name-changes

What documentation changes (if any) are needed to support this PR?:
None

Font Awesome 5 replaced the refresh icon from 4 with fa-sync:
https://fontawesome.com/how-to-use/on-the-web/setup/upgrading-from-version-4#name-changes

Fixes #941

Signed-off-by: Mcat12 <[email protected]>
@AzureMarker AzureMarker added this to the v5.0 milestone May 19, 2019
@AzureMarker AzureMarker requested a review from a team May 19, 2019 21:19
@AzureMarker AzureMarker merged commit 5563dbe into devel May 19, 2019
@AzureMarker AzureMarker deleted the fix/refresh-icon branch May 19, 2019 22:12
@AzureMarker AzureMarker modified the milestones: v5.0, v4.3.2 Sep 12, 2019
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-4-3-2-release-notes/23852/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants