Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reload icon missing on blacklist/whitelist site #941

Closed
3 tasks done
Th3M3 opened this issue May 19, 2019 · 0 comments
Closed
3 tasks done

reload icon missing on blacklist/whitelist site #941

Th3M3 opened this issue May 19, 2019 · 0 comments

Comments

@Th3M3
Copy link
Contributor

Th3M3 commented May 19, 2019

In raising this issue, I confirm the following: {please fill the checkboxes, e.g: [X]}

How familiar are you with the the source code relevant to this issue?:

7


Expected behaviour:

After Update to v4.3 the reload icon should still be shown on blacklist and whitelist site.

Actual behaviour:

The button is still there, but the icon is missing:

Unbenannt

Steps to reproduce:

Open the blacklist or the whitelist site.

Debug token provided by uploading pihole -d log:

-

Troubleshooting undertaken, and/or other relevant information:

In File list.php, line 45, fa-refresh must be replaced by fa-sync-alt or fa-sync.
Possibly also in other php files.
(https://fontawesome.com/icons?d=gallery&q=refresh&m=free)

AzureMarker added a commit that referenced this issue May 19, 2019
Font Awesome 5 replaced the refresh icon from 4 with fa-sync:
https://fontawesome.com/how-to-use/on-the-web/setup/upgrading-from-version-4#name-changes

Fixes #941

Signed-off-by: Mcat12 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants