Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LCARS top navbar #2025

Merged
merged 1 commit into from
Dec 25, 2021
Merged

Fix LCARS top navbar #2025

merged 1 commit into from
Dec 25, 2021

Conversation

rdwebdesign
Copy link
Member

@rdwebdesign rdwebdesign commented Dec 24, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Other PRs introduced visual changes to the default themes.
The LCARS theme changes the size and position of many items, requiring new CSS to accommodate these visual changes.

This PR fixes these issues.

How does this PR accomplish the above?:

Adding new CSS.
top_navbar_fix

What documentation changes (if any) are needed to support this PR?:
none

@yubiuser
Copy link
Member

Can you provide a before and after screenshot?

Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2021-12-25 21-26-23

@DL6ER DL6ER merged commit 3e192ed into pi-hole:devel Dec 25, 2021
@rdwebdesign rdwebdesign deleted the lcars_top_navbar branch December 25, 2021 21:11
@rdwebdesign rdwebdesign restored the lcars_top_navbar branch December 25, 2021 23:05
@yubiuser
Copy link
Member

Reverted by #2027

yubiuser pushed a commit that referenced this pull request Dec 26, 2021
@PromoFaux PromoFaux mentioned this pull request Jan 4, 2022
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-13-web-v5-10-and-core-v5-8-released/52254/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants