Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bounce animation to Pi-hole diagnosis warning triangle #1990

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Nov 29, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

This PR aims to make the Pi-hole diagnosis system, containing many helpful messages to aid users helping themselves.

How does this PR accomplish the above?:

Add an animation to the warning icon. Furthermore, making the icon twice as large on all screens.
ezgif-3-ddf519f74cc4

Full screen preview:

ezgif-2-31021110ffa5

What documentation changes (if any) are needed to support this PR?:

None

@DL6ER DL6ER force-pushed the tweak/triangle_animation-bounce branch from 7dc10b0 to b34dd11 Compare November 29, 2021 16:19
@DL6ER
Copy link
Member Author

DL6ER commented Nov 29, 2021

Pushed away prettier complaints

@yubiuser yubiuser merged commit 00acbff into devel Nov 30, 2021
@yubiuser yubiuser deleted the tweak/triangle_animation-bounce branch November 30, 2021 11:58
@DL6ER DL6ER mentioned this pull request Dec 22, 2021
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-12-web-v5-9-and-core-v5-7-released/51795/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants