Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add absent <thead> tags #1991

Merged
merged 2 commits into from
Dec 21, 2021
Merged

Add absent <thead> tags #1991

merged 2 commits into from
Dec 21, 2021

Conversation

paul-man
Copy link
Contributor

@paul-man paul-man commented Dec 1, 2021

Signed-off-by: Paul Mannarino [email protected]

By submitting this pull request, I confirm the following: {please fill any appropriate checkboxes, e.g: [X]}

{Please ensure that your pull request is for the 'devel' branch!}

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Resolve #1378
Regain my honor for abandoning #1397

How does this PR accomplish the above?:

Utilize for header rows in all tables

What documentation changes (if any) are needed to support this PR?:

None


I tried to reopen my previous PR but it seems I don't have permission to do so. Apologies for the PR clutter and for never following up on #1397 :/

@XhmikosR To answer your question on my old PR, it appears the only place a <thead> is being generated by javascript is for the custom tooltips. In that case my code change shouldn't be double adding any <thead>.

cc: @PromoFaux

Signed-off-by: Paul Mannarino <[email protected]>
@paul-man paul-man changed the base branch from master to devel December 2, 2021 23:32
@DL6ER DL6ER merged commit 2f52ab3 into pi-hole:devel Dec 21, 2021
@DL6ER DL6ER mentioned this pull request Dec 22, 2021
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-12-web-v5-9-and-core-v5-7-released/51795/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tables: make sure we use a thead
3 participants