Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tables: make sure we use a thead #1378

Closed
XhmikosR opened this issue May 25, 2020 · 2 comments · Fixed by #1991
Closed

Tables: make sure we use a thead #1378

XhmikosR opened this issue May 25, 2020 · 2 comments · Fixed by #1991
Labels
Code maintenance Help Wanted

Comments

@XhmikosR
Copy link
Contributor

There are some tables that don't have a thead. We should make sure every table has a thead assuming it's needed, instead of adding a tr in tbody that behaves like a thead.
This was referenced May 26, 2020
Closed
Closed
@paul-man paul-man mentioned this issue Dec 1, 2021
Merged
9 tasks
@paul-man
Copy link
Contributor

paul-man commented Jan 4, 2022

This was resolved in #1991 which was included in the most recent release, should this be closed?

@yubiuser
Copy link
Member

yubiuser commented Jan 4, 2022

Yes :)

The fixed was released with
https://discourse.pi-hole.net/t/pi-hole-ftl-v5-12-web-v5-9-and-core-v5-7-released/51795/1

@yubiuser yubiuser closed this as completed Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code maintenance Help Wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add absent <thead> tags paul-man/AdminLTE
3 participants
@XhmikosR @paul-man @yubiuser